From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 2/3] benchmarks/gem_syslatency: Allow limiting to just 1 CPU hog
Date: Tue, 22 May 2018 12:38:26 +0100 [thread overview]
Message-ID: <8be11a80-59e3-fb4f-920c-14ca53f7ffb6@linux.intel.com> (raw)
In-Reply-To: <20180522110044.26439-2-chris@chris-wilson.co.uk>
On 22/05/2018 12:00, Chris Wilson wrote:
> Normally we use a hog per CPU to ensure that the system is fully
> loaded to see how much latency we cause. For simple sanitychecking, allow
> ourselves to limit it to just one CPU hog.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> benchmarks/gem_syslatency.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/benchmarks/gem_syslatency.c b/benchmarks/gem_syslatency.c
> index 9160e2199..d1056773a 100644
> --- a/benchmarks/gem_syslatency.c
> +++ b/benchmarks/gem_syslatency.c
> @@ -311,8 +311,11 @@ int main(int argc, char **argv)
> bool interrupts = false;
> int n, c;
>
> - while ((c = getopt(argc, argv, "t:f:bmni")) != -1) {
> + while ((c = getopt(argc, argv, "t:f:bmni1")) != -1) {
> switch (c) {
> + case '1':
> + ncpus = 1;
> + break;
> case 'n': /* dry run, measure baseline system latency */
> enable_gem_sysbusy = 0;
> break;
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-05-22 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 11:00 [PATCH i-g-t 1/3] benchmarks/gem_syslatency: Pass a write hazard around Chris Wilson
2018-05-22 11:00 ` [PATCH i-g-t 2/3] benchmarks/gem_syslatency: Allow limiting to just 1 CPU hog Chris Wilson
2018-05-22 11:38 ` Tvrtko Ursulin [this message]
2018-05-22 11:00 ` [PATCH i-g-t 3/3] benchmarks/gem_syslatency: Specify batch duration Chris Wilson
2018-05-22 11:49 ` Tvrtko Ursulin
2018-05-22 11:24 ` [PATCH i-g-t 1/3] benchmarks/gem_syslatency: Pass a write hazard around Mika Kuoppala
2018-05-22 11:28 ` Chris Wilson
2018-05-22 11:37 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8be11a80-59e3-fb4f-920c-14ca53f7ffb6@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox