Re: [PATCH 5/8] drm/imagination: annotate pvr_fw_version_packed() with __maybe_unused

[Matt Coster <Matt.Coster@imgtec.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1319 bytes --]

On 10/09/2024 11:03, Jani Nikula wrote:
> Building with clang and and W=1 leads to warning about unused
> pvr_fw_version_packed(). Fix by annotating it with __maybe_unused.
> 
> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> inline functions for W=1 build").
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

I've been meaning to do something about this for a while, thanks!

Reviewed-by: Matt Coster <matt.coster@imgtec.com>

Cheers,
Matt

-- 
Matt Coster
E: matt.coster@imgtec.com

> ---
> 
> Cc: Frank Binns <frank.binns@imgtec.com>
> Cc: Matt Coster <matt.coster@imgtec.com>
> Cc: Nathan Chancellor <nathan@kernel.org>
> ---
>  drivers/gpu/drm/imagination/pvr_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_drv.c b/drivers/gpu/drm/imagination/pvr_drv.c
> index 1a0cb7aa9cea..684a9b9a2247 100644
> --- a/drivers/gpu/drm/imagination/pvr_drv.c
> +++ b/drivers/gpu/drm/imagination/pvr_drv.c
> @@ -220,7 +220,7 @@ pvr_ioctl_get_bo_mmap_offset(struct drm_device *drm_dev, void *raw_args,
>  	return ret;
>  }
>  
> -static __always_inline u64
> +static __always_inline __maybe_unused u64
>  pvr_fw_version_packed(u32 major, u32 minor)
>  {
>  	return ((u64)major << 32) | minor;

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]