From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: remove some limited use register access wrappers
Date: Mon, 28 Nov 2022 22:35:25 +0100 [thread overview]
Message-ID: <8e342bd4-0163-09b2-4a09-5462676f6f6f@intel.com> (raw)
In-Reply-To: <20221123164916.4128733-1-jani.nikula@intel.com>
On 23.11.2022 17:49, Jani Nikula wrote:
> Remove rmw_set(), rmw_clear(), clear_register(), rmw_set_fw(), and
> rmw_clear_fw(). They're just one too many levels of abstraction for
> register access, for very specific purposes.
>
> clear_register() seems like a micro-optimization bypassing the write
> when the register is already clear, but that trick has ceased to work
> since commit 06b975d58fd6 ("drm/i915: make intel_uncore_rmw() write
> unconditionally"). Just clear the register in the most obvious way.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
next prev parent reply other threads:[~2022-11-28 21:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 16:49 [Intel-gfx] [PATCH] drm/i915/gt: remove some limited use register access wrappers Jani Nikula
2022-11-23 16:59 ` Rodrigo Vivi
2022-11-23 20:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-28 18:38 ` [Intel-gfx] [PATCH] " Matt Roper
2022-11-28 21:35 ` Andrzej Hajda [this message]
2022-12-05 12:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: remove some limited use register access wrappers (rev2) Patchwork
2022-12-05 14:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e342bd4-0163-09b2-4a09-5462676f6f6f@intel.com \
--to=andrzej.hajda@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox