From: Jani Nikula <jani.nikula@intel.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] drm/i915/psr: fix pipe to vblank conversion
Date: Mon, 10 Nov 2025 13:21:38 +0200 [thread overview]
Message-ID: <8e51dd88918a9986049d4cbc29b219ab82bb1b9b@intel.com> (raw)
In-Reply-To: <df54e434d95553c02fe9e7a8607cbc25652ef107.camel@intel.com>
On Fri, 07 Nov 2025, "Hogander, Jouni" <jouni.hogander@intel.com> wrote:
> On Thu, 2025-11-06 at 22:00 +0200, Jani Nikula wrote:
>> First, we can't assume pipe == crtc index. If a pipe is fused off in
>> between, it no longer holds. intel_crtc_for_pipe() is the only proper
>> way to get from a pipe to the corresponding crtc.
>>
>> Second, drivers aren't supposed to access or index drm->vblank[]
>> directly. There's drm_crtc_vblank_crtc() for this.
>>
>> Use both functions to fix the pipe to vblank conversion.
>
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
Thanks, pushed to din.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-11-10 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 20:00 [PATCH] drm/i915/psr: fix pipe to vblank conversion Jani Nikula
2025-11-06 21:24 ` ✓ i915.CI.BAT: success for " Patchwork
2025-11-07 7:03 ` [PATCH] " Hogander, Jouni
2025-11-10 11:21 ` Jani Nikula [this message]
2025-11-07 15:14 ` ✗ i915.CI.Full: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e51dd88918a9986049d4cbc29b219ab82bb1b9b@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox