From: "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>,
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/hdcp: Assign correct hdcp content type
Date: Thu, 22 Jun 2023 20:28:49 +0530 [thread overview]
Message-ID: <8f583bf8-ee4e-7db7-f2d8-eea0bc36c8f1@intel.com> (raw)
In-Reply-To: <20230622083254.2057102-1-suraj.kandpal@intel.com>
LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Please add Fixes tag.
Regards,
Ankit
On 6/22/2023 2:02 PM, Suraj Kandpal wrote:
> Currently hdcp->content_type is being assigned the content_type field
> in drm_connector_state which is wrong and instead it needs to be
> assigned hdcp_content_type field from drm_connector_state
>
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 5ed450111f77..34fabadefaf6 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -2358,7 +2358,7 @@ int intel_hdcp_enable(struct intel_atomic_state *state,
> mutex_lock(&dig_port->hdcp_mutex);
> drm_WARN_ON(&i915->drm,
> hdcp->value == DRM_MODE_CONTENT_PROTECTION_ENABLED);
> - hdcp->content_type = (u8)conn_state->content_type;
> + hdcp->content_type = (u8)conn_state->hdcp_content_type;
>
> if (intel_crtc_has_type(pipe_config, INTEL_OUTPUT_DP_MST)) {
> hdcp->cpu_transcoder = pipe_config->mst_master_transcoder;
next prev parent reply other threads:[~2023-06-22 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 8:32 [Intel-gfx] [PATCH] drm/i915/hdcp: Assign correct hdcp content type Suraj Kandpal
2023-06-22 9:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-06-22 12:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-06-22 14:58 ` Nautiyal, Ankit K [this message]
2023-06-22 17:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-23 5:25 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f583bf8-ee4e-7db7-f2d8-eea0bc36c8f1@intel.com \
--to=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox