From: "Gupta, Anshuman" <anshuman.gupta@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: Sean Paul <seanpaul@chromium.org>,
"C, Ramalingam" <ramalingam.c@intel.com>,
"B S, Karthik" <karthik.b.s@intel.com>,
"Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
Subject: Re: [Intel-gfx] i915 MST HDCP code looks broken
Date: Mon, 4 Oct 2021 15:04:01 +0000 [thread overview]
Message-ID: <9078bb70f03e41738043771fb1d89ff3@intel.com> (raw)
In-Reply-To: <YVrctgdJ8EYdW9i0@intel.com>
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Monday, October 4, 2021 4:22 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Sean Paul <seanpaul@chromium.org>; Gupta, Anshuman
> <anshuman.gupta@intel.com>; C, Ramalingam <ramalingam.c@intel.com>; B S,
> Karthik <karthik.b.s@intel.com>
> Subject: i915 MST HDCP code looks broken
>
> Hi,
>
> I took a quick peek at intel_dp_add_mst_connector() the other day and noticed
> that it calls intel_dp_hdcp_init() and passes in the SST dig_port. And digging in a
> bit further that seems to clobber all kinds of things in dig_port->hdcp_port_data.
> This looks rather broken to me.
>
> So has anyone actually thought what happens if you first use MST on the port,
> and then later switch to SST on the same port?
AFAIU there shouldn't be , when the last connector of MST topology get destroyed and it switches to SST mode on same port.
The base static connector of same dig_port should get connected and will call intel_dp_init_connector()->intel_dp_hdcp_init().
What is the specific sequence is broken here , is it the connector destroy path ?
> --
> Ville Syrjälä
> Intel
next prev parent reply other threads:[~2021-10-04 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 10:51 [Intel-gfx] i915 MST HDCP code looks broken Ville Syrjälä
2021-10-04 15:04 ` Gupta, Anshuman [this message]
2021-10-04 18:38 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9078bb70f03e41738043771fb1d89ff3@intel.com \
--to=anshuman.gupta@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=ramalingam.c@intel.com \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox