From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Chiou, Cooper" <cooper.chiou@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
"Tseng, William" <william.tseng@intel.com>,
"Chen, Rong A" <rong.a.chen@intel.com>
Subject: Re: [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9
Date: Wed, 10 Mar 2021 10:19:12 +0000 [thread overview]
Message-ID: <928454d4-8ae6-9b02-747f-fecdcc1e6ac4@linux.intel.com> (raw)
In-Reply-To: <SA2PR11MB496960ABA0D7C5E2A53A2C099D939@SA2PR11MB4969.namprd11.prod.outlook.com>
Hi,
On 08/03/2021 17:32, Chiou, Cooper wrote:
> I've tested on GLK, KBL, CFL Intel NUC devices and got the following performance results, there is no performance regression per my testing.
>
> Patch: [v5] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9
> Test suite: phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultimate.1.GranParadisoIsland.frames_per_second
> Kernel version: 5.12.0-rc1 (drm-tip)
>
> a. Device: Intel NUC kit NUC7JY Gemini Lake Celeron J4005 @2.7GHz (2 Cores)
> Without patch, fps=57.45
> With patch, fps=57.49
> b. Device: Intel NUC kit NUC8BEH Coffee Lake Core i3-8109U @3.6GHz(4 Cores)
> Without patch, fps=117.23
> With patch, fps=117.27
> c. Device: Intel NUC kit NUC7i3BNH Kaby Lake Core i3-7100U @2.4GHz(4 Cores)
> Without patch, fps=114.05
> With patch, fps=114.34
>
> Meanwhile, Intel lkp team has validated performance on lkp-kbl-nuc1 and no regression.
> f69d02e37a85645a d912096c40cdc3bc9364966971 testcase/testparams/testbox
> ---------------- -------------------------- ---------------------------
> %stddev change %stddev
> \ | \
> 29.79 29.67
> phoronix-test-suite/performance-true-Fullscreen-Ultimate-1-Gran_Paradiso_Island__Approxima-supertuxkart-1.5.2-ucode=0xde/lkp-kbl-nuc1
> 29.79 29.67 GEO-MEAN phoronix-test-suite.supertuxkart.1280x1024.Fullscreen.Ultimate.1.GranParadisoIsland.frames_per_second
>
CI results are green so that is good.
Do the machines used for performance testing include unusual fusing?
Worrying thing is that we were never able to reproduce the reported
regression in house due lack of identical machine, right? Although I
guess avoiding hangs trumps performance.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-03-10 10:19 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 18:07 [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2020-09-16 19:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-09-21 9:22 ` [Intel-gfx] [drm/i915] 04ff178484: phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultimate.1.GranParadisoIsland.frames_per_second -30.4% regression kernel test robot
2021-01-21 14:18 ` Chiou, Cooper
2021-02-08 0:45 ` kernel test robot
2021-02-17 6:56 ` Chiou, Cooper
2021-02-09 6:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2) Patchwork
2021-02-09 7:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-02-09 11:37 ` Chiou, Cooper
2021-02-17 10:24 ` Tvrtko Ursulin
2021-03-04 18:37 ` Chiou, Cooper
2021-03-04 20:10 ` Matt Roper
2021-02-17 9:31 ` [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Chiou, Cooper
2021-02-17 9:59 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev3) Patchwork
2021-03-02 3:55 ` [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-03-02 5:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev4) Patchwork
2021-03-02 6:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-02 6:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-03-02 6:27 ` [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-03-02 7:17 ` Chiou, Cooper
2021-03-04 9:12 ` Tvrtko Ursulin
2021-03-04 9:19 ` Chris Wilson
2021-03-04 11:56 ` Chris Wilson
2021-03-05 0:53 ` Chris Wilson
2021-03-05 9:23 ` Tvrtko Ursulin
2021-03-05 12:20 ` Chris Wilson
2021-03-05 15:23 ` Chris Wilson
2021-03-05 15:24 ` Chiou, Cooper
2021-03-05 16:01 ` Tvrtko Ursulin
2021-03-06 7:16 ` Chiou, Cooper
2021-03-08 17:32 ` Chiou, Cooper
2021-03-10 10:19 ` Tvrtko Ursulin [this message]
2021-03-10 10:54 ` Chris Wilson
2021-03-11 2:36 ` Chiou, Cooper
2021-03-11 1:27 ` Chiou, Cooper
2021-03-11 10:12 ` Tvrtko Ursulin
2021-03-11 10:47 ` Chiou, Cooper
2021-03-02 7:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev5) Patchwork
2021-03-02 7:28 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-03-03 18:09 ` [Intel-gfx] [PATCH v4] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-03-03 19:54 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev6) Patchwork
2021-03-05 12:58 ` [Intel-gfx] [PATCH v5] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-03-06 7:19 ` Chiou, Cooper
2021-03-10 3:09 ` Chiou, Cooper
2021-03-11 10:45 ` Tvrtko Ursulin
2021-03-11 11:11 ` Joonas Lahtinen
2021-03-23 16:30 ` Rodrigo Vivi
2021-03-05 14:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev7) Patchwork
2021-03-05 17:57 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-21 18:05 ` [Intel-gfx] [PATCH v6] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-10-21 22:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev8) Patchwork
2021-10-22 4:14 ` [Intel-gfx] [PATCH v7] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-10-22 13:23 ` Tvrtko Ursulin
2021-10-22 5:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev9) Patchwork
2021-10-22 9:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-25 4:26 ` [Intel-gfx] [PATCH v8] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-11-01 10:15 ` Tvrtko Ursulin
2021-11-01 10:40 ` Joonas Lahtinen
2021-11-01 10:49 ` Tvrtko Ursulin
2021-10-25 5:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev10) Patchwork
2021-10-25 9:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev11) Patchwork
2021-10-25 12:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=928454d4-8ae6-9b02-747f-fecdcc1e6ac4@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=cooper.chiou@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rong.a.chen@intel.com \
--cc=william.tseng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox