From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org
Cc: daniel@ffwll.ch
Subject: Re: [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine
Date: Wed, 22 Sep 2021 11:27:23 +0100 [thread overview]
Message-ID: <92e428d5-76d5-e63f-5322-aa5cf1a1952a@linux.intel.com> (raw)
In-Reply-To: <20210922091044.2612-19-christian.koenig@amd.com>
On 22/09/2021 10:10, Christian König wrote:
> This is maybe even a fix since the RCU usage here looks incorrect.
I'm afraid I gazumped you here by removing this function shortly before
you posted the respin.
Regards,
Tvrtko
> Signed-off-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_object.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.h b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> index 48112b9d76df..e20efffce3a9 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.h
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.h
> @@ -507,16 +507,16 @@ static inline struct intel_engine_cs *
> i915_gem_object_last_write_engine(struct drm_i915_gem_object *obj)
> {
> struct intel_engine_cs *engine = NULL;
> + struct dma_resv_iter cursor;
> struct dma_fence *fence;
>
> - rcu_read_lock();
> - fence = dma_resv_get_excl_unlocked(obj->base.resv);
> - rcu_read_unlock();
> -
> - if (fence && dma_fence_is_i915(fence) && !dma_fence_is_signaled(fence))
> - engine = to_request(fence)->engine;
> - dma_fence_put(fence);
> -
> + dma_resv_iter_begin(&cursor, obj->base.resv, false);
> + dma_resv_for_each_fence_unlocked(&cursor, fence) {
> + if (fence && dma_fence_is_i915(fence) &&
> + !dma_fence_is_signaled(fence))
> + engine = to_request(fence)->engine;
> + }
> + dma_resv_iter_end(&cursor);
> return engine;
> }
>
>
next prev parent reply other threads:[~2021-09-22 10:27 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 9:10 [Intel-gfx] Deploying new iterator interface for dma-buf Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4 Christian König
2021-09-22 14:36 ` Tvrtko Ursulin
2021-09-22 14:50 ` Christian König
2021-09-22 15:09 ` Tvrtko Ursulin
2021-09-22 9:10 ` [Intel-gfx] [PATCH 02/26] dma-buf: add dma_resv_for_each_fence Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 03/26] dma-buf: use new iterator in dma_resv_copy_fences Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 04/26] dma-buf: use new iterator in dma_resv_get_fences v2 Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 05/26] dma-buf: use new iterator in dma_resv_wait_timeout Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 06/26] dma-buf: use new iterator in dma_resv_test_signaled Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 07/26] drm/ttm: use the new iterator in ttm_bo_flush_all_fences Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 08/26] drm/amdgpu: use the new iterator in amdgpu_sync_resv Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 09/26] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 10/26] drm/msm: use new iterator in msm_gem_describe Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 11/26] drm/radeon: use new iterator in radeon_sync_resv Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 12/26] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2 Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl Christian König
2021-09-22 10:21 ` Tvrtko Ursulin
2021-09-22 11:46 ` Tvrtko Ursulin
2021-09-22 12:15 ` Christian König
2021-09-22 12:20 ` Tvrtko Ursulin
2021-09-22 12:22 ` Christian König
2021-09-22 14:31 ` Christian König
2021-09-22 14:39 ` Tvrtko Ursulin
2021-09-22 9:10 ` [Intel-gfx] [PATCH 14/26] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3 Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 15/26] drm/i915: use the new iterator in i915_request_await_object v2 Christian König
2021-09-22 10:34 ` Tvrtko Ursulin
2021-09-22 9:10 ` [Intel-gfx] [PATCH 16/26] drm/i915: use new iterator in i915_gem_object_wait_reservation Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 17/26] drm/i915: use new iterator in i915_gem_object_wait_priority Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine Christian König
2021-09-22 10:27 ` Tvrtko Ursulin [this message]
2021-09-22 11:00 ` Christian König
2021-09-22 11:12 ` Tvrtko Ursulin
2021-09-22 9:10 ` [Intel-gfx] [PATCH 19/26] drm/i915: use new cursor in intel_prepare_plane_fb Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 20/26] drm: use new iterator in drm_gem_fence_array_add_implicit v3 Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 21/26] drm: use new iterator in drm_gem_plane_helper_prepare_fb Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 22/26] drm/nouveau: use the new iterator in nouveau_fence_sync Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 23/26] drm/nouveau: use the new interator in nv50_wndw_prepare_fb Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 24/26] drm/etnaviv: use new iterator in etnaviv_gem_describe Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 25/26] drm/etnaviv: replace dma_resv_get_excl_unlocked Christian König
2021-09-22 9:10 ` [Intel-gfx] [PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked Christian König
2021-09-22 12:55 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4 Patchwork
-- strict thread matches above, loose matches on Subject: below --
2021-09-21 17:36 [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v3 Christian König
2021-09-21 17:36 ` [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine Christian König
2021-09-13 13:16 [Intel-gfx] Deploying new iterator interface for dma-buf Christian König
2021-09-13 13:16 ` [Intel-gfx] [PATCH 18/26] drm/i915: use new iterator in i915_gem_object_last_write_engine Christian König
2021-09-14 12:27 ` Tvrtko Ursulin
2021-09-14 12:32 ` Christian König
2021-09-14 12:47 ` Tvrtko Ursulin
2021-09-15 11:19 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92e428d5-76d5-e63f-5322-aa5cf1a1952a@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox