public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH i-g-t] i915/gem_ctx_engine: Prevent preemption
Date: Wed, 19 Jun 2019 07:32:05 +0100	[thread overview]
Message-ID: <94b19e73-a22b-4042-8196-c24399bf6734@linux.intel.com> (raw)
In-Reply-To: <20190618202139.1481-1-chris@chris-wilson.co.uk>


On 18/06/2019 21:21, Chris Wilson wrote:
> In order to pin the engine as busy, we have to prevent the kernel from
> executing other independent work ahead of our plug, so tell the spinner
> to not allow preemption.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/i915/gem_ctx_engines.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_ctx_engines.c b/tests/i915/gem_ctx_engines.c
> index 3ecade417..d47cbdd7c 100644
> --- a/tests/i915/gem_ctx_engines.c
> +++ b/tests/i915/gem_ctx_engines.c
> @@ -283,7 +283,8 @@ static void execute_one(int i915)
>   
>   			spin = igt_spin_new(i915,
>   					    .ctx = param.ctx_id,
> -					    .engine = 0);
> +					    .engine = 0,
> +					    .flags = IGT_SPIN_NO_PREEMPTION);
>   
>   			igt_debug("Testing with map of %d engines\n", i + 1);
>   			memset(&engines.engines, -1, sizeof(engines.engines));
> 

The no-op batch preempts the spinner? How does that affect the busy 
check on the no-op batch?

Regards,

Tvrtko


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-06-19  6:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18 20:21 [PATCH i-g-t] i915/gem_ctx_engine: Prevent preemption Chris Wilson
2019-06-18 21:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-06-19  6:32 ` Tvrtko Ursulin [this message]
2019-06-19  8:34   ` [PATCH i-g-t] " Chris Wilson
2019-06-19  8:44     ` Tvrtko Ursulin
2019-06-19  8:46       ` Chris Wilson
2019-06-19 16:06 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94b19e73-a22b-4042-8196-c24399bf6734@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox