From: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
To: "Jani Nikula" <jani.nikula@linux.intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Deak, Imre" <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v6 0/4] drm/i915/display: stop HPD workers before display driver unregister
Date: Tue, 2 Aug 2022 15:24:11 +0300 [thread overview]
Message-ID: <94d076ad-b0ff-0469-a741-255360a7da41@intel.com> (raw)
In-Reply-To: <20220722125143.1604709-1-andrzej.hajda@intel.com>
Hi Jani, Ville and Imre,
If there are no problems after reviewing this patch series, could you
please merge it?
Many thanks,
G.G.
On 7/22/22 3:51 PM, Andrzej Hajda wrote:
> Hi Jani, Ville, Arun,
>
> This patchset is replacement of patch
> "drm/i915/display: disable HPD workers before display driver unregister" [1].
> Ive decided to split patch into two parts - fbdev and MST, there are different
> issues.
> Ive also dropped shutdown path, as it has slightly different requirements,
> and more importantly I am not able to test properly.
>
> v2 (thx Arun for review):
> - reword of commit message (Arun)
> - intel_fbdev_hpd_set_suspend replaced with intel_fbdev_set_suspend (Arun)
> v3:
> - new patch adding suspended flag, to handle
> https://gitlab.freedesktop.org/drm/intel/-/issues/5950
> v4:
> - check suspend flag also in i915_digport_work_func
> v5:
> - added patch blocking FB creation in case HPD is supended,
> - added R-B from Arun to patch 3, thx
> v6:
> - finally, after getting direct access to bat-rpls-2, I have found the source of last WARN,
> intel_fbdev_hpd_set_suspend was not called in case of deferred setup, fixed in patch 2.
>
> [1]: https://patchwork.freedesktop.org/series/103811/
>
> Regards
> Andrzej
>
>
> Andrzej Hajda (4):
> drm/i915/hpd: postpone HPD cancel work after last user suspension
> drm/i915/fbdev: suspend HPD before fbdev unregistration
> drm/i915/display: add hotplug.suspended flag
> drm/i915/fbdev: do not create fbdev if HPD is suspended
>
> drivers/gpu/drm/i915/display/intel_display.c | 3 +++
> drivers/gpu/drm/i915/display/intel_fbdev.c | 12 ++++++++++--
> drivers/gpu/drm/i915/display/intel_hotplug.c | 11 ++++++++++-
> drivers/gpu/drm/i915/display/intel_hotplug.h | 2 +-
> drivers/gpu/drm/i915/i915_driver.c | 4 ++--
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> drivers/gpu/drm/i915/i915_irq.c | 1 -
> 7 files changed, 28 insertions(+), 7 deletions(-)
>
next prev parent reply other threads:[~2022-08-02 12:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 12:51 [Intel-gfx] [PATCH v6 0/4] drm/i915/display: stop HPD workers before display driver unregister Andrzej Hajda
2022-07-22 12:51 ` [Intel-gfx] [PATCH v6 1/4] drm/i915/hpd: postpone HPD cancel work after last user suspension Andrzej Hajda
2022-08-22 17:08 ` Imre Deak
2022-08-23 7:41 ` Jani Nikula
2022-08-23 9:10 ` Imre Deak
2022-07-22 12:51 ` [Intel-gfx] [PATCH v6 2/4] drm/i915/fbdev: suspend HPD before fbdev unregistration Andrzej Hajda
2022-08-22 17:10 ` Imre Deak
2022-07-22 12:51 ` [Intel-gfx] [PATCH v6 3/4] drm/i915/display: add hotplug.suspended flag Andrzej Hajda
2022-08-22 17:27 ` Imre Deak
2022-08-23 21:48 ` Andrzej Hajda
2022-08-24 11:22 ` Imre Deak
2022-08-25 11:24 ` Andrzej Hajda
2022-08-25 14:57 ` Imre Deak
2022-07-22 12:51 ` [Intel-gfx] [PATCH v6 4/4] drm/i915/fbdev: do not create fbdev if HPD is suspended Andrzej Hajda
2022-07-26 6:50 ` Murthy, Arun R
2022-08-22 17:28 ` Imre Deak
2022-07-22 13:08 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: stop HPD workers before display driver unregister (rev12) Patchwork
2022-07-22 13:32 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-22 15:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-07-22 16:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: stop HPD workers before display driver unregister (rev13) Patchwork
2022-07-22 17:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-22 20:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-24 14:46 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/display: stop HPD workers before display driver unregister (rev14) Patchwork
2022-07-24 15:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-07-24 16:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-08-02 12:24 ` Gwan-gyeong Mun [this message]
2022-08-11 8:33 ` [Intel-gfx] [PATCH v6 0/4] drm/i915/display: stop HPD workers before display driver unregister Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94d076ad-b0ff-0469-a741-255360a7da41@intel.com \
--to=gwan-gyeong.mun@intel.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox