From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: support forcing the page size with lmem
Date: Thu, 24 Jun 2021 13:08:22 +0200 [thread overview]
Message-ID: <9563165c-2edd-02c1-1335-efdd68e4b214@linux.intel.com> (raw)
In-Reply-To: <20210623141615.291391-1-matthew.auld@intel.com>
On 6/23/21 4:16 PM, Matthew Auld wrote:
> For some specialised objects we might need something larger than the
> regions min_page_size due to some hw restriction, and slightly more
> hairy is needing something smaller with the guarantee that such objects
> will never be inserted into any GTT, which is the case for the paging
> structures.
>
> This also fixes how we setup the BO page_alignment, if we later migrate
> the object somewhere else. For example if the placements are {SMEM,
> LMEM}, then we might get this wrong. Pushing the min_page_size behaviour
> into the manager should fix this.
>
> v2(Thomas): push the default page size behaviour into buddy_man, and let
> the user override it with the page-alignment, which looks cleaner
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-06-24 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 14:16 [Intel-gfx] [PATCH v2 1/2] drm/i915: support forcing the page size with lmem Matthew Auld
2021-06-23 14:16 ` [Intel-gfx] [PATCH v2 2/2] drm/i915/gtt: ignore min_page_size for paging structures Matthew Auld
2021-06-23 15:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915: support forcing the page size with lmem Patchwork
2021-06-23 15:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-06-23 16:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-23 19:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-24 11:08 ` Thomas Hellström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9563165c-2edd-02c1-1335-efdd68e4b214@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox