From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Tvrtko Ursulin <tursulin@ursulin.net>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] scripts/trace.pl: Support class:instance engine tracepoints
Date: Tue, 5 Jun 2018 18:15:46 +0100 [thread overview]
Message-ID: <968beaa4-415e-9e69-78df-8968b8023ba1@intel.com> (raw)
In-Reply-To: <20180605165051.29136-1-tvrtko.ursulin@linux.intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
On 05/06/18 17:50, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> New way of describing engines needs the tool to be adapted to understand it.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> scripts/trace.pl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/trace.pl b/scripts/trace.pl
> index 068eee68b30c..ea6c667696f4 100755
> --- a/scripts/trace.pl
> +++ b/scripts/trace.pl
> @@ -378,6 +378,8 @@ while (<>) {
> $k = 'global' if $k eq 'global_seqno';
> chop $v if substr($v, -1, 1) eq ',';
> $tp{$k} = $v;
> +
> + $tp{'ring'} = $tp{'engine'} if $k eq 'engine';
> }
>
> next if exists $tp{'ring'} and exists $ignore_ring{$tp{'ring'}};
> @@ -631,7 +633,7 @@ foreach my $gid (sort keys %rings) {
>
> # Extract all GPU busy intervals and sort them.
> foreach my $key (@sorted_keys) {
> - next unless $db{$key}->{'ring'} == $ring;
> + next unless $db{$key}->{'ring'} eq $ring;
> push @s_, $db{$key}->{'start'};
> push @e_, $db{$key}->{'end'};
> die if $db{$key}->{'start'} > $db{$key}->{'end'};
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2018-06-05 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 16:50 [PATCH i-g-t 1/2] scripts/trace.pl: Support class:instance engine tracepoints Tvrtko Ursulin
2018-06-05 16:50 ` [PATCH i-g-t 2/2] intel_gpu_overlay: Update for " Tvrtko Ursulin
2018-06-05 17:14 ` Lionel Landwerlin
2018-06-05 19:40 ` [igt-dev] " Chris Wilson
2018-06-06 9:02 ` [PATCH i-g-t v2 " Tvrtko Ursulin
2018-06-06 10:29 ` Lionel Landwerlin
2018-06-06 11:01 ` Tvrtko Ursulin
2018-06-05 17:15 ` Lionel Landwerlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=968beaa4-415e-9e69-78df-8968b8023ba1@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox