Re: [PATCH 13/32] drm/i915/xe3p_lpd: Remove gamma,csc bottom color checks

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 10/15/2025 8:45 AM, Gustavo Sousa wrote:
> From: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
> 
> With Xe3p_LPD, the SKL_BOTTOM_COLOR_GAMMA_ENABLE and
> SKL_BOTTOM_COLOR_CSC_ENABLE bits are being removed. Thus, we need not
> set gamma_enable nor csc_enable in crtc_state.
> 
> Note that GAMMA_MODE.POST_CSC_GAMMA_ENABLE and CSC_MODE.ICL_CSC_ENABLE
> are the documented alternatives for the bottom color bits being removed.
> But as these suggested bits are being checked in state checker as part
> of gamma_mode, csc_mode fields and as gamma_enable/csc_enable are not
> being used anywhere else functionally post ICL, we need not set these
> fields in crtc_state.


LGTM
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> 
> Bspec: 69734
> Signed-off-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_color.c | 13 +++++++------
>   1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> index 51db70d07fae..9102f3eb0bc4 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -1090,18 +1090,19 @@ static void skl_get_config(struct intel_crtc_state *crtc_state)
>   {
>   	struct intel_display *display = to_intel_display(crtc_state);
>   	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
> -	u32 tmp;
>   
>   	crtc_state->gamma_mode = hsw_read_gamma_mode(crtc);
>   	crtc_state->csc_mode = ilk_read_csc_mode(crtc);
>   
> -	tmp = intel_de_read(display, SKL_BOTTOM_COLOR(crtc->pipe));
> +	if (DISPLAY_VER(display) < 35) {
> +		u32 tmp = intel_de_read(display, SKL_BOTTOM_COLOR(crtc->pipe));
>   
> -	if (tmp & SKL_BOTTOM_COLOR_GAMMA_ENABLE)
> -		crtc_state->gamma_enable = true;
> +		if (tmp & SKL_BOTTOM_COLOR_GAMMA_ENABLE)
> +			crtc_state->gamma_enable = true;
>   
> -	if (tmp & SKL_BOTTOM_COLOR_CSC_ENABLE)
> -		crtc_state->csc_enable = true;
> +		if (tmp & SKL_BOTTOM_COLOR_CSC_ENABLE)
> +			crtc_state->csc_enable = true;
> +	}
>   }
>   
>   static void skl_color_commit_arm(struct intel_dsb *dsb,
>