From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fixup dma_fence_wait usage
Date: Tue, 2 Nov 2021 16:53:43 +0100 [thread overview]
Message-ID: <9b449605-c2d2-c415-af28-822765f921bc@linux.intel.com> (raw)
In-Reply-To: <20211102155055.100138-1-matthew.auld@intel.com>
On 11/2/21 16:50, Matthew Auld wrote:
> dma_fence_wait expects a boolean for whether it should be interruptible,
> not a timeout value.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_vma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> index 90546fa58fc1..8781c4f61952 100644
> --- a/drivers/gpu/drm/i915/i915_vma.c
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -349,7 +349,7 @@ int i915_vma_wait_for_bind(struct i915_vma *vma)
> fence = dma_fence_get_rcu_safe(&vma->active.excl.fence);
> rcu_read_unlock();
> if (fence) {
> - err = dma_fence_wait(fence, MAX_SCHEDULE_TIMEOUT);
> + err = dma_fence_wait(fence, true);
> dma_fence_put(fence);
> }
> }
LGTM. Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
next prev parent reply other threads:[~2021-11-02 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 15:50 [Intel-gfx] [PATCH] drm/i915: fixup dma_fence_wait usage Matthew Auld
2021-11-02 15:53 ` Thomas Hellström [this message]
2021-11-02 17:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-02 18:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-11-03 7:46 ` Matthew Auld
2021-11-03 15:32 ` Vudum, Lakshminarayana
2021-11-03 15:29 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b449605-c2d2-c415-af28-822765f921bc@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox