From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [Intel-gfx] [PATCH 2/2] dma-buf: Fix dma_resv_test_signaled.
Date: Fri, 15 Oct 2021 14:52:34 +0200 [thread overview]
Message-ID: <9b7e43bb-e175-0aff-2cc1-cc10236fe8e5@linux.intel.com> (raw)
In-Reply-To: <ebf0714c-2f49-a0ad-1861-16394ade468d@amd.com>
Op 15-10-2021 om 14:07 schreef Christian König:
> Am 15.10.21 um 13:57 schrieb Maarten Lankhorst:
>> Commit 7fa828cb9265 ("dma-buf: use new iterator in dma_resv_test_signaled")
>> accidentally forgot to test whether the dma-buf is actually signaled, breaking
>> pretty much everything depending on it.
>
> NAK, the dma_resv_for_each_fence_unlocked() returns only unsignaled fences. So the code is correct as it is.
That seems like it might cause some unexpected behavior when that function is called with one of the fence locks held, if it calls dma_fence_signal().
Could it be changed to only test the signaled bit, in which case this patch would still be useful?
Or at least add some lockdep annotations, that fence->lock might be taken. So any hangs would at least be easy to spot with lockdep.
~Maarten
next prev parent reply other threads:[~2021-10-15 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 11:57 [Intel-gfx] [PATCH 0/2] dma-buf: Fix breakages from dma_resv_iter conversion Maarten Lankhorst
2021-10-15 11:57 ` [Intel-gfx] [PATCH 1/2] dma-buf: Fix dma_resv_wait_timeout handling of timeout = 0 Maarten Lankhorst
2021-10-18 11:20 ` [Intel-gfx] [Linaro-mm-sig] " Christian König
2021-10-15 11:57 ` [Intel-gfx] [PATCH 2/2] dma-buf: Fix dma_resv_test_signaled Maarten Lankhorst
2021-10-15 12:07 ` Christian König
2021-10-15 12:52 ` Maarten Lankhorst [this message]
2021-10-15 12:56 ` [Intel-gfx] [Linaro-mm-sig] " Christian König
2021-10-21 12:08 ` Daniel Vetter
2021-10-15 12:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf: Fix breakages from dma_resv_iter conversion Patchwork
2021-10-15 13:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-15 19:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b7e43bb-e175-0aff-2cc1-cc10236fe8e5@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox