Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>,
	<intel-gfx@lists.freedesktop.org>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
	Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	Krzysztof Niemiec <krzysztof.niemiec@intel.com>,
	Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Add vgpu.entry list initialization
Date: Fri, 23 Jan 2026 12:49:11 +0100	[thread overview]
Message-ID: <DFVY1WBM8OVB.1KJQLWZ2NYTWZ@intel.com> (raw)
In-Reply-To: <7updbd6x7fmw4g3tdf3r27xblf4www7xxsxyrncc35jokiuxvr@rflx6oxm5au5>

On Fri Jan 23, 2026 at 11:11 AM CET, Krzysztof Karas wrote:
> It was observed that during fault injection testing the
> vgpu.entry remains uninitialized when taking the error path,
> which results in warnings [1]:
>
> <6> [491.828427] list_del corruption, ffff88812cd2d0c8->next is NULL
> <4> [491.828430] WARNING: lib/list_debug.c:52 at
>  __list_del_entry_valid_or_report+0x6f/0x120, CPU#2: i915_module_loa/2921
>
> Add initialization step to intel_vgpu_detect().
>
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> ---
>
> Example of failure from intel-gfx-ci:
> https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8711/shard-dg2-5/igt@i915_module_load@fault-injection.html#dmesg-warnings385
>
>  drivers/gpu/drm/i915/i915_vgpu.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_vgpu.c b/drivers/gpu/drm/i915/i915_vgpu.c
> index d29a06ea51a5..362282b20f7b 100644
> --- a/drivers/gpu/drm/i915/i915_vgpu.c
> +++ b/drivers/gpu/drm/i915/i915_vgpu.c
> @@ -67,6 +67,7 @@ void intel_vgpu_detect(struct drm_i915_private *dev_priv)
>  	u64 magic;
>  	u16 version_major;
>  	void __iomem *shared_area;
> +	INIT_LIST_HEAD(&dev_priv->vgpu.entry);
This may not be the ideal place to initialize this list. It
would be preferable to do it once, closer to where the list is
declared. Initializing it near i915_driver_create() would likely
be better.

-- 
Best regards,
Sebastian


  reply	other threads:[~2026-01-23 11:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23 10:11 [PATCH] drm/i915: Add vgpu.entry list initialization Krzysztof Karas
2026-01-23 11:49 ` Sebastian Brzezinka [this message]
2026-01-23 11:59 ` ✓ i915.CI.BAT: success for " Patchwork
2026-01-23 15:09 ` [PATCH] " Janusz Krzysztofik
2026-01-23 19:40 ` ✓ i915.CI.Full: success for " Patchwork
2026-01-28 16:56 ` [PATCH] " Andi Shyti
2026-01-28 17:38   ` Jani Nikula
2026-01-28 22:39     ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFVY1WBM8OVB.1KJQLWZ2NYTWZ@intel.com \
    --to=sebastian.brzezinka@intel.com \
    --cc=andi.shyti@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=krzysztof.karas@intel.com \
    --cc=krzysztof.niemiec@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox