Re: [PATCH v2 0/2] DRM device registration fixes

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi Krzysztof,

On Thu Jul 16, 2026 at 2:00 PM CEST, Krzysztof Niemiec wrote:
> This series contains patches pertaining the drm_dev_register() and
> drm_dev_unregister() functions. Turns out drm_dev_register() doesn't
> properly unwind its effects in the error path, causing confusion and
> bugs.
>
> Additionally, a related patch for i915 is bundled, as i915 mistakenly
> calls drm_dev_unregister() in the error path triggered by failing
> drm_dev_register(), which on one hand introduced a WARN_ON() in
> drm_client_sysrq_unregister(), caused by calling it without a previous
> _register() (as it was skipped in drm_dev_register()); but on the other
> hand silenced yet another WARN_ON() later on in the error path in
> drm_mode_config_cleanup(). With the other patch, the driver can just
> handle the error from drm_dev_register() cleanly without calling
> drm_dev_unregister(). This is explained in detail in both the patches.
As has been said, you could reorder the patches. Other than that LGTM.
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

-- 
Best regards,
Sebastian