From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Matteo Iervasi <matteoiervasi@gmail.com>,
Jani Nikula <jani.nikula@intel.com>,
Albert Astals Cid <aacid@kde.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Emanuele Panigati <ilpanich@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure
Date: Mon, 11 Jan 2021 20:28:45 +0200 [thread overview]
Message-ID: <X/yY3Tvk8gq+Eg8W@intel.com> (raw)
In-Reply-To: <20210107182026.24848-1-ville.syrjala@linux.intel.com>
On Thu, Jan 07, 2021 at 08:20:25PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Some new eDP panels don't like to operate at the max parameters, and
> instead we need to go for an optimal confiugration. That unfortunately
> doesn't work with older eDP panels which are generally only guaranteed
> to work at the max parameters.
>
> To solve these two conflicting requirements let's start with the optimal
> setup, and if that fails we start again with the max parameters. The
> downside is probably an extra modeset when we switch strategies but
> I don't see a good way to avoid that.
>
> For a bit of history we first tried to go for the fast+narrow in
> commit 7769db588384 ("drm/i915/dp: optimize eDP 1.4+ link config
> fast and narrow"). but that had to be reverted due to regression
> on older panels in commit f11cb1c19ad0 ("drm/i915/dp: revert back
> to max link rate and lane count on eDP"). So now we try to get
> the best of both worlds by using both strategies.
Pushed. Fingers crossed for no regressions...
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-01-11 18:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 18:20 [Intel-gfx] [PATCH 1/2] drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure Ville Syrjala
2021-01-07 18:20 ` [Intel-gfx] [PATCH 2/2] drm: Refactor intel_dp_compute_link_config_*() Ville Syrjala
2021-01-07 19:38 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure Patchwork
2021-01-07 20:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-08 1:25 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-01-11 18:28 ` Ville Syrjälä [this message]
2021-05-10 8:07 ` [Intel-gfx] [PATCH 1/2] " Emanuele Panigati
2021-05-10 18:06 ` Albert Astals Cid
2021-05-11 3:29 ` Kai-Heng Feng
2021-05-11 12:57 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/yY3Tvk8gq+Eg8W@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=aacid@kde.org \
--cc=ilpanich@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=matteoiervasi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox