Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 0/4] Simplify uncore register updates
Date: Wed, 12 Oct 2022 00:18:22 +0200	[thread overview]
Message-ID: <Y0XrroTbf/YSlJP5@ashyti-mobl2.lan> (raw)
In-Reply-To: <20221006163200.2803722-1-andrzej.hajda@intel.com>

Hi Andrzej,

On Thu, Oct 06, 2022 at 06:31:56PM +0200, Andrzej Hajda wrote:
> This patchset should not modify behaviour of the code (except patch 3).
> It just replaces sequence of uncore read/modify/write with single call.
> Moreover it replaces nested pointers with alias if there is one.
> All patches except 3rd, were generated using coccinelle (quite ugly)
> and adjusted in some cases by hand.
> 
> v2:
> - addressed comments by Andi, Jani and lkp,
> - despite Jani objections Ive left 1st patch with hope he will change his mind,
>   if not it can be safely ignored :),
> - converted few more read/modifiy/write sequences in last patch,
> - style adjustements to make checkpatch happy.
> 
> Regards
> Andrzej
> 
> 
> Andrzej Hajda (4):
>   drm/i915/display: Use drm_device alias if defined
>   drm/i915/display: Use intel_uncore alias if defined
>   drm/i915: make intel_uncore_rmw() write unconditionally
>   drm/i915: use proper helper for register updates

Pushed in drm-intel-next

Thanks,
Andi

>  drivers/gpu/drm/i915/display/icl_dsi.c        |   4 +-
>  drivers/gpu/drm/i915/display/intel_display.c  |   3 +-
>  .../drm/i915/display/intel_display_debugfs.c  |   2 +-
>  drivers/gpu/drm/i915/display/intel_hotplug.c  |   2 +-
>  drivers/gpu/drm/i915/display/intel_lvds.c     |  13 +-
>  drivers/gpu/drm/i915/display/intel_opregion.c |   2 +-
>  drivers/gpu/drm/i915/display/intel_tc.c       |   9 +-
>  drivers/gpu/drm/i915/display/vlv_dsi.c        |   2 +-
>  drivers/gpu/drm/i915/i915_irq.c               | 237 +++++++-----------
>  drivers/gpu/drm/i915/intel_pm.c               |  60 ++---
>  drivers/gpu/drm/i915/intel_uncore.h           |   8 +-
>  drivers/gpu/drm/i915/vlv_suspend.c            |  28 +--
>  12 files changed, 133 insertions(+), 237 deletions(-)
> 
> -- 
> 2.34.1

      parent reply	other threads:[~2022-10-11 22:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06 16:31 [Intel-gfx] [PATCH v2 0/4] Simplify uncore register updates Andrzej Hajda
2022-10-06 16:31 ` [Intel-gfx] [PATCH v2 1/4] drm/i915/display: Use drm_device alias if defined Andrzej Hajda
2022-10-06 16:41   ` Ville Syrjälä
2022-10-06 20:48     ` [Intel-gfx] [PATCH v3 1/4] drm/i915/display: remove drm_device aliases Andrzej Hajda
2022-10-10 14:31       ` Andi Shyti
2022-10-10 15:22         ` Jani Nikula
2022-10-11 10:09         ` Andi Shyti
2022-10-11 10:13           ` Jani Nikula
2022-10-11 10:17             ` Jani Nikula
2022-10-11 10:28               ` Andi Shyti
2022-10-11 11:19             ` Tvrtko Ursulin
2022-10-06 16:31 ` [Intel-gfx] [PATCH v2 2/4] drm/i915/display: Use intel_uncore alias if defined Andrzej Hajda
2022-10-06 16:31 ` [Intel-gfx] [PATCH v2 3/4] drm/i915: make intel_uncore_rmw() write unconditionally Andrzej Hajda
2022-10-06 16:32 ` [Intel-gfx] [PATCH v2 4/4] drm/i915: use proper helper for register updates Andrzej Hajda
2022-10-14 17:57   ` Matt Roper
2022-10-17  9:28     ` Andrzej Hajda
2022-10-06 16:51 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Simplify uncore register updates (rev2) Patchwork
2022-10-06 17:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-06 21:26 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Simplify uncore register updates (rev3) Patchwork
2022-10-06 21:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-10-07  5:00 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for Simplify uncore register updates (rev2) Patchwork
2022-10-11 22:18 ` Andi Shyti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0XrroTbf/YSlJP5@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox