From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12
Date: Thu, 13 Oct 2022 13:30:49 +0300 [thread overview]
Message-ID: <Y0fo2VO+NUocRJtK@intel.com> (raw)
In-Reply-To: <20221013051124.1093410-1-ankit.k.nautiyal@intel.com>
On Thu, Oct 13, 2022 at 10:41:24AM +0530, Ankit Nautiyal wrote:
> Defeature Display Interlace support.
> Support for Interlace modes is removed from Gen 12 onwards.
> For DP we do not support interlace modes (except for very old
> platforms).
Yes we do. Specifically G4X/VLV/CHV do not support it,
everything else does.
> Pruning the interlaced modes for HDMI for Display >=12.
> Bspec: 50490
The tagging there seems borked. Only ADLS shows it as not supported.
>
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdmi.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index 93519fb23d9d..791bfb062c49 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -1990,6 +1990,9 @@ intel_hdmi_mode_valid(struct drm_connector *connector,
> if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
> return MODE_NO_DBLESCAN;
>
> + if (DISPLAY_VER(dev_priv) >= 12 && mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return MODE_NO_INTERLACE;
> +
These are pointless if the connector doesn't declare interlace_allowed
anyway.
> if ((mode->flags & DRM_MODE_FLAG_3D_MASK) == DRM_MODE_FLAG_3D_FRAME_PACKING)
> clock *= 2;
>
> @@ -2247,6 +2250,10 @@ int intel_hdmi_compute_config(struct intel_encoder *encoder,
> if (adjusted_mode->flags & DRM_MODE_FLAG_DBLSCAN)
> return -EINVAL;
>
> + if (DISPLAY_VER(dev_priv) >= 12 &&
> + adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
> + return -EINVAL;
> +
> pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
> pipe_config->has_hdmi_sink = intel_has_hdmi_sink(intel_hdmi,
> conn_state);
> @@ -2956,7 +2963,9 @@ void intel_hdmi_init_connector(struct intel_digital_port *dig_port,
> ddc);
> drm_connector_helper_add(connector, &intel_hdmi_connector_helper_funcs);
>
> - connector->interlace_allowed = true;
> + if (DISPLAY_VER(dev_priv) < 12)
> + connector->interlace_allowed = true;
> +
> connector->stereo_allowed = true;
>
> if (DISPLAY_VER(dev_priv) >= 10)
> --
> 2.25.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-10-13 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 5:11 [Intel-gfx] [PATCH] drm/i915/hdmi: Prune Interlaced modes for Display >= 12 Ankit Nautiyal
2022-10-13 5:24 ` Navare, Manasi
2022-10-13 6:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-10-13 7:58 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-13 10:30 ` Ville Syrjälä [this message]
2022-10-13 11:59 ` [Intel-gfx] [PATCH] " Nautiyal, Ankit K
2022-10-13 12:10 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0fo2VO+NUocRJtK@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox