From: Andi Shyti <andi.shyti@linux.intel.com>
To: Karolina Drobnik <karolina.drobnik@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH] i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl
Date: Thu, 27 Oct 2022 12:40:34 +0200 [thread overview]
Message-ID: <Y1pgIvGVhvCXOFLT@ashyti-mobl2.lan> (raw)
In-Reply-To: <20221025091903.986819-1-karolina.drobnik@intel.com>
Hi Karolina,
On Tue, Oct 25, 2022 at 11:19:03AM +0200, Karolina Drobnik wrote:
> We know that as long as GEM context create ioctl succeeds, a context was
> created. There is no need to write about it, especially when such a message
> heavily pollutes dmesg and makes debugging actual errors harder.
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Karolina Drobnik <karolina.drobnik@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
pushed to drm-intel-gt-next.
Thank you!
Andi
> ---
> drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> index 1e29b1e6d186..1456ca87c04e 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c
> @@ -2298,7 +2298,6 @@ int i915_gem_context_create_ioctl(struct drm_device *dev, void *data,
> }
>
> args->ctx_id = id;
> - drm_dbg(&i915->drm, "HW context %d created\n", args->ctx_id);
>
> return 0;
>
> --
> 2.25.1
prev parent reply other threads:[~2022-10-27 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 9:19 [Intel-gfx] [PATCH] i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl Karolina Drobnik
2022-10-25 9:27 ` Andi Shyti
2022-10-25 10:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-10-25 12:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-27 10:40 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1pgIvGVhvCXOFLT@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=karolina.drobnik@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox