From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Das, Nirmoy" <nirmoy.das@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, matthew.auld@intel.com,
chris.p.wilson@intel.com, Nirmoy Das <nirmoy.das@intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload
Date: Wed, 2 Nov 2022 19:55:17 +0200 [thread overview]
Message-ID: <Y2KvBTY2ueEWpFAj@intel.com> (raw)
In-Reply-To: <e3930f78-5062-0e7c-9858-d54e7b661e25@linux.intel.com>
On Mon, Oct 24, 2022 at 10:08:29AM +0200, Das, Nirmoy wrote:
>
> On 10/21/2022 6:34 PM, Ville Syrjälä wrote:
> > On Fri, Sep 23, 2022 at 09:35:14AM +0200, Nirmoy Das wrote:
> >> i915_gem_drain_freed_objects() might not be enough to
> >> free all the objects and RCU delayed work might get
> >> scheduled after the i915 device struct gets freed.
> >>
> >> Call i915_gem_drain_workqueue() to catch all RCU delayed work.
> > shard-snb is stil hitting the mm.shrink_count WARNn reliably,
> > and things go downhill after that.
>
>
> Looks better now again. Going to look into that.
Looks to be still hitting it occasionally in module reload tests:
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7033/shard-snb5/igt@i915_module_load@reload.html
https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7035/shard-snb7/igt@perf_pmu@module-unload.html
>
>
> Thanks,
>
> Nirmoy
>
> >
> >> Suggested-by: Chris Wilson <chris.p.wilson@intel.com>
> >> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/i915_gem.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> >> index 88df9a35e0fe..7541028caebd 100644
> >> --- a/drivers/gpu/drm/i915/i915_gem.c
> >> +++ b/drivers/gpu/drm/i915/i915_gem.c
> >> @@ -1278,7 +1278,7 @@ void i915_gem_init_early(struct drm_i915_private *dev_priv)
> >>
> >> void i915_gem_cleanup_early(struct drm_i915_private *dev_priv)
> >> {
> >> - i915_gem_drain_freed_objects(dev_priv);
> >> + i915_gem_drain_workqueue(dev_priv);
> >> GEM_BUG_ON(!llist_empty(&dev_priv->mm.free_list));
> >> GEM_BUG_ON(atomic_read(&dev_priv->mm.free_count));
> >> drm_WARN_ON(&dev_priv->drm, dev_priv->mm.shrink_count);
> >> --
> >> 2.37.3
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-11-02 17:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 7:35 [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Nirmoy Das
2022-09-23 7:35 ` [Intel-gfx] [PATCH 2/2] drm/i915: remove excessive i915_gem_drain_freed_objects Nirmoy Das
2022-09-27 7:43 ` Andrzej Hajda
2022-09-23 8:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload Patchwork
2022-09-23 19:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-26 20:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix a potential UAF at device unload (rev2) Patchwork
2022-09-27 5:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-09-27 7:43 ` [Intel-gfx] [PATCH 1/2] drm/i915: Fix a potential UAF at device unload Andrzej Hajda
2022-09-29 11:32 ` Andi Shyti
2022-09-29 11:36 ` Das, Nirmoy
2022-10-21 16:34 ` Ville Syrjälä
2022-10-24 8:08 ` Das, Nirmoy
2022-11-02 17:55 ` Ville Syrjälä [this message]
2022-11-02 18:37 ` Das, Nirmoy
-- strict thread matches above, loose matches on Subject: below --
2022-09-08 20:07 Nirmoy Das
2022-09-09 8:55 ` Tvrtko Ursulin
2022-09-21 15:53 ` Das, Nirmoy
2022-09-22 9:37 ` Tvrtko Ursulin
2022-09-22 12:11 ` Das, Nirmoy
2022-09-22 12:28 ` Tvrtko Ursulin
2022-09-22 12:32 ` Das, Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2KvBTY2ueEWpFAj@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris.p.wilson@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=nirmoy.das@intel.com \
--cc=nirmoy.das@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox