From: Andi Shyti <andi.shyti@linux.intel.com>
To: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: intel-gfx@lists.freedesktop.org, matthew.auld@intel.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Do not set cache_dirty for DGFX
Date: Wed, 2 Nov 2022 23:31:29 +0100 [thread overview]
Message-ID: <Y2LvwWE4VY4APkTf@ashyti-mobl2.lan> (raw)
In-Reply-To: <20221102051416.27327-1-niranjana.vishwanathapura@intel.com>
Hi Niranjana,
On Tue, Nov 01, 2022 at 10:14:16PM -0700, Niranjana Vishwanathapura wrote:
> Currently on DG1, which do not have LLC, we hit the below
> warning while rebinding an userptr invalidated object.
>
> WARNING: CPU: 4 PID: 13008 at drivers/gpu/drm/i915/gem/i915_gem_pages.c:34 __i915_gem_object_set_pages+0x296/0x2d0 [i915]
> ...
> RIP: 0010:__i915_gem_object_set_pages+0x296/0x2d0 [i915]
> ...
> Call Trace:
> <TASK>
> i915_gem_userptr_get_pages+0x175/0x1a0 [i915]
> ____i915_gem_object_get_pages+0x32/0xb0 [i915]
> i915_gem_object_userptr_submit_init+0x286/0x470 [i915]
> eb_lookup_vmas+0x2ff/0xcf0 [i915]
> ? __intel_wakeref_get_first+0x55/0xb0 [i915]
> i915_gem_do_execbuffer+0x785/0x21d0 [i915]
> i915_gem_execbuffer2_ioctl+0xe7/0x3d0 [i915]
>
> We shouldn't be setting the obj->cache_dirty for DGFX,
> fix it.
>
> Suggested-by: Matthew Auld <matthew.auld@intel.com>
> Reported-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Pushed in drm-intel-gt-next.
Thanks,
Andi
prev parent reply other threads:[~2022-11-02 22:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 5:14 [Intel-gfx] [PATCH] drm/i915: Do not set cache_dirty for DGFX Niranjana Vishwanathapura
2022-11-02 6:21 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2022-11-02 6:45 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-11-02 7:39 ` [Intel-gfx] [PATCH] " Das, Nirmoy
2022-11-02 10:36 ` Matthew Auld
2022-11-02 16:09 ` Das, Nirmoy
2022-11-02 16:35 ` Niranjana Vishwanathapura
2022-11-02 21:59 ` Andi Shyti
2022-11-02 22:31 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2LvwWE4VY4APkTf@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=niranjana.vishwanathapura@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox