Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Nirmoy Das <nirmoy.das@intel.com>,
	Chris Wilson <chris.p.wilson@intel.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>
Subject: Re: [Intel-gfx] [PATCH v6 2/3] drm/i915/selftests: use live_subtests for live_migrate
Date: Tue, 6 Dec 2022 17:01:07 +0100	[thread overview]
Message-ID: <Y49nQw5QJE3ZPdvK@ashyti-mobl2.lan> (raw)
In-Reply-To: <20221202122844.428006-2-matthew.auld@intel.com>

Hi Matt,

On Fri, Dec 02, 2022 at 12:28:43PM +0000, Matthew Auld wrote:
> Probably a good idea to do an igt_flush_test() at the end of each
> subtest, just to be sure the previous work has been flushed and doesn't
> somehow interfere with the current subtest.
> 
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Chris Wilson <chris.p.wilson@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Nirmoy Das <nirmoy.das@intel.com>

[...]

> @@ -647,7 +661,7 @@ int intel_migrate_live_selftests(struct drm_i915_private *i915)
>  	if (!gt->migrate.context)
>  		return 0;
>  
> -	return i915_subtests(tests, &gt->migrate);
> +	return intel_gt_live_subtests(tests, gt);

yes... this calls the gt teardown function that waits for all the
works to end and yields to userspace signals... makes sense.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi

  parent reply	other threads:[~2022-12-06 16:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-02 12:28 [Intel-gfx] [PATCH v6 1/3] drm/i915/migrate: Account for the reserved_space Matthew Auld
2022-12-02 12:28 ` [Intel-gfx] [PATCH v6 2/3] drm/i915/selftests: use live_subtests for live_migrate Matthew Auld
2022-12-06 13:14   ` Andrzej Hajda
2022-12-06 16:01   ` Andi Shyti [this message]
2022-12-02 12:28 ` [Intel-gfx] [PATCH v6 3/3] drm/i915/selftests: exercise emit_pte() with nearly full ring Matthew Auld
2022-12-06 16:19   ` Andi Shyti
2022-12-02 13:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/3] drm/i915/migrate: Account for the reserved_space Patchwork
2022-12-02 14:06 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-12-08 10:15   ` Matthew Auld
2022-12-06 12:49 ` [Intel-gfx] [PATCH v6 1/3] " Andrzej Hajda
2022-12-06 15:55 ` Andi Shyti
2022-12-09 13:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/3] drm/i915/migrate: Account for the reserved_space (rev2) Patchwork
2022-12-09 22:46 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y49nQw5QJE3ZPdvK@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=andrzej.hajda@intel.com \
    --cc=chris.p.wilson@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox