From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
Cc: Alan Previn <alan.previn.teres.alexis@intel.com>,
intel-gfx@lists.freedesktop.org,
Brian Norris <briannorris@chromium.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/huc: fix leak of debug object in huc load fence on driver unload
Date: Mon, 28 Nov 2022 15:08:31 +0200 [thread overview]
Message-ID: <Y4Syz9kXp1JPal4I@intel.com> (raw)
In-Reply-To: <119a95f9-9c54-d811-8c2f-f3ecd52258c9@intel.com>
On Mon, Nov 28, 2022 at 01:10:58AM -0800, Ceraolo Spurio, Daniele wrote:
>
>
> On 11/25/2022 5:54 AM, Ville Syrjälä wrote:
> > On Thu, Nov 10, 2022 at 04:56:51PM -0800, Daniele Ceraolo Spurio wrote:
> >> The fence is always initialized in huc_init_early, but the cleanup in
> >> huc_fini is only being run if HuC is enabled. This causes a leaking of
> >> the debug object when HuC is disabled/not supported, which can in turn
> >> trigger a warning if we try to register a new debug offset at the same
> >> address on driver reload.
> >>
> >> To fix the issue, make sure to always run the cleanup code.
> > This oopsing in ci now. Somehow the patchwork run did not
> > hit that oops.
>
> Can you point me to the oops log? I opened a few recent runs at random
> but I wasn't able to find it.
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12425/fi-blb-e6850/igt@core_hotunplug@unbind-rebind.html
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-11-28 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 0:56 [Intel-gfx] [PATCH] drm/i915/huc: fix leak of debug object in huc load fence on driver unload Daniele Ceraolo Spurio
2022-11-11 6:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-12 0:53 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-11-17 1:29 ` [Intel-gfx] [PATCH] " Brian Norris
2022-11-17 15:57 ` Ceraolo Spurio, Daniele
2022-11-22 23:07 ` John Harrison
2022-11-25 13:54 ` Ville Syrjälä
2022-11-28 9:10 ` Ceraolo Spurio, Daniele
2022-11-28 13:08 ` Ville Syrjälä [this message]
2022-11-28 16:32 ` Ceraolo Spurio, Daniele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4Syz9kXp1JPal4I@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=briannorris@chromium.org \
--cc=daniele.ceraolospurio@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox