From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Chris Wilson <chris@chris-wilson.co.uk>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@gmail.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked
Date: Wed, 7 Dec 2022 11:00:20 -0500 [thread overview]
Message-ID: <Y5C4lKIuMhBorik0@intel.com> (raw)
In-Reply-To: <20221207112909.2655251-1-linmq006@gmail.com>
On Wed, Dec 07, 2022 at 03:29:09PM +0400, Miaoqian Lin wrote:
> intel_uncore_forcewake_put__locked() is used to release a reference.
>
> Fixes: a6111f7b6604 ("drm/i915: Reduce locking in execlist command submission")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and will push this right now...
> ---
> drivers/gpu/drm/i915/intel_uncore.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index 5cd423c7b646..acb40543eb32 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -819,9 +819,9 @@ void intel_uncore_forcewake_flush(struct intel_uncore *uncore,
> }
>
> /**
> - * intel_uncore_forcewake_put__locked - grab forcewake domain references
> + * intel_uncore_forcewake_put__locked - release forcewake domain references
> * @uncore: the intel_uncore structure
> - * @fw_domains: forcewake domains to get reference on
> + * @fw_domains: forcewake domains to put references
> *
> * See intel_uncore_forcewake_put(). This variant places the onus
> * on the caller to explicitly handle the dev_priv->uncore.lock spinlock.
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-12-07 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 11:29 [Intel-gfx] [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked Miaoqian Lin
2022-12-07 16:00 ` Rodrigo Vivi [this message]
2022-12-07 16:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-12-07 21:17 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5C4lKIuMhBorik0@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox