From: Daniel Vetter <daniel@ffwll.ch>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support
Date: Fri, 12 Mar 2021 15:15:03 +0100 [thread overview]
Message-ID: <YEt3Z2GbRZmmFkE4@phenom.ffwll.local> (raw)
In-Reply-To: <17824b43488.2817.c6988b7ea6112e3e892765a0d4287e0c@jlekstrand.net>
On Thu, Mar 11, 2021 at 10:31:33PM -0600, Jason Ekstrand wrote:
>
> On March 11, 2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote:
>
> > On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote:
> > >
> > > libdrm has supported the newer execbuffer2 ioctl and using it by default
> > > when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22
> > > which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time
> > > both used libdrm and so did the Intel X11 back-end. The SNA back-end
> > > for X11 has always used execbuffer2.
> > >
> > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
> > > ---
> > > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------
> > > drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 -
> > > drivers/gpu/drm/i915/i915_drv.c | 2 +-
> > > 3 files changed, 1 insertion(+), 103 deletions(-)
> >
> > Don't we want to clean up references to legacy execbuffer in
> > include/uapi/drm/i915_drm.h too?
>
> I thought about that but Daniel said we should leave them. Maybe a comment
> is in order?
These headers are copied unchanged to userspace for building. We don't use
kernel-headers packages directly in any of our userspace (I hope at
least), but still better safe than sorry and avoid compilation failures
simply due to updated uapi headers that lost a few old things.
Also we need at least the struct size because that's encoded in the ioctl
number, and at that point might as well keep the entire thing.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-03-12 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 21:00 [Intel-gfx] [PATCH] i915: Drop legacy execbuffer support Jason Ekstrand
2021-03-10 21:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-03-10 21:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-10 22:04 ` [Intel-gfx] [PATCH] " Keith Packard
2021-03-11 19:08 ` Dave Airlie
2021-03-10 23:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
2021-03-12 2:25 ` [Intel-gfx] [PATCH] " Dixit, Ashutosh
2021-03-12 4:31 ` Jason Ekstrand
2021-03-12 5:58 ` Dixit, Ashutosh
2021-03-12 14:15 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEt3Z2GbRZmmFkE4@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox