From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 20/23] drm/i915: s/stride/src_stride/ in the intel_remapped_plane_info struct
Date: Fri, 12 Mar 2021 19:51:35 +0200 [thread overview]
Message-ID: <YEuqJ0t+6gzW3Tcp@intel.com> (raw)
In-Reply-To: <20210310221736.2963264-21-imre.deak@intel.com>
On Thu, Mar 11, 2021 at 12:17:33AM +0200, Imre Deak wrote:
> An upcoming patch adds a new dst_stride field to the
> intel_remapped_plane_info struct, so for clarity rename the current
> stride field to src_stride.
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fb.c | 12 ++---
> drivers/gpu/drm/i915/gt/intel_ggtt.c | 4 +-
> drivers/gpu/drm/i915/i915_debugfs.c | 8 +--
> drivers/gpu/drm/i915/i915_vma_types.h | 2 +-
> drivers/gpu/drm/i915/selftests/i915_vma.c | 60 +++++++++++------------
> 5 files changed, 43 insertions(+), 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> index 51c56f0a4a99..6cf0820e3177 100644
> --- a/drivers/gpu/drm/i915/display/intel_fb.c
> +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> @@ -591,8 +591,8 @@ static void init_plane_view_dims(const struct intel_framebuffer *fb, int color_p
> intel_tile_dims(&fb->base, color_plane, &dims->tile_width, &dims->tile_height);
> }
>
> -static unsigned int plane_view_stride_tiles(const struct intel_framebuffer *fb, int color_plane,
> - const struct fb_plane_view_dims *dims)
> +static unsigned int plane_view_src_stride_tiles(const struct intel_framebuffer *fb, int color_plane,
> + const struct fb_plane_view_dims *dims)
> {
> const struct drm_framebuffer *drm_fb = &fb->base;
>
> @@ -619,7 +619,7 @@ static u32 calc_plane_remap_info(const struct intel_framebuffer *fb, int color_p
> unsigned int tile_width = dims->tile_width;
> unsigned int tile_height = dims->tile_height;
> unsigned int tile_size = intel_tile_size(i915);
> - unsigned int stride_tiles = plane_view_stride_tiles(fb, color_plane, dims);
> + unsigned int src_stride_tiles = plane_view_src_stride_tiles(fb, color_plane, dims);
> unsigned int width_tiles = DIV_ROUND_UP(x + dims->width, dims->tile_width);
> unsigned int height_tiles = plane_view_tile_rows(fb, color_plane, dims, y);
> unsigned int pitch_tiles;
> @@ -627,12 +627,12 @@ static u32 calc_plane_remap_info(const struct intel_framebuffer *fb, int color_p
>
> drm_WARN_ON(&i915->drm,
> overflows_type(obj_offset, gtt_remap_info->offset) ||
> - overflows_type(stride_tiles, gtt_remap_info->stride) ||
> + overflows_type(src_stride_tiles, gtt_remap_info->src_stride) ||
> overflows_type(width_tiles, gtt_remap_info->width) ||
> overflows_type(height_tiles, gtt_remap_info->height));
>
> gtt_remap_info->offset = obj_offset;
> - gtt_remap_info->stride = stride_tiles;
> + gtt_remap_info->src_stride = src_stride_tiles;
> gtt_remap_info->width = width_tiles;
> gtt_remap_info->height = height_tiles;
>
> @@ -691,7 +691,7 @@ static int calc_plane_normal_size(const struct intel_framebuffer *fb, int color_
> x * drm_fb->format->cpp[color_plane];
> pages = DIV_ROUND_UP(size, intel_tile_size(i915));
> } else {
> - pages = plane_view_stride_tiles(fb, color_plane, dims) *
> + pages = plane_view_src_stride_tiles(fb, color_plane, dims) *
> plane_view_tile_rows(fb, color_plane, dims, y);
> }
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> index b0b8ded834f0..9a5b038e1ea3 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> @@ -1314,7 +1314,7 @@ intel_rotate_pages(struct intel_rotation_info *rot_info,
> for (i = 0 ; i < ARRAY_SIZE(rot_info->plane); i++) {
> sg = rotate_pages(obj, rot_info->plane[i].offset,
> rot_info->plane[i].width, rot_info->plane[i].height,
> - rot_info->plane[i].stride, st, sg);
> + rot_info->plane[i].src_stride, st, sg);
> }
>
> return st;
> @@ -1398,7 +1398,7 @@ intel_remap_pages(struct intel_remapped_info *rem_info,
> for (i = 0 ; i < ARRAY_SIZE(rem_info->plane); i++) {
> sg = remap_pages(obj, rem_info->plane[i].offset,
> rem_info->plane[i].width, rem_info->plane[i].height,
> - rem_info->plane[i].stride, st, sg);
> + rem_info->plane[i].src_stride, st, sg);
> }
>
> i915_sg_trim(st);
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 51133b8fabb4..48032c0288ee 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -176,11 +176,11 @@ i915_debugfs_describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
> seq_printf(m, ", rotated [(%ux%u, stride=%u, offset=%u), (%ux%u, stride=%u, offset=%u)]",
> vma->ggtt_view.rotated.plane[0].width,
> vma->ggtt_view.rotated.plane[0].height,
> - vma->ggtt_view.rotated.plane[0].stride,
> + vma->ggtt_view.rotated.plane[0].src_stride,
> vma->ggtt_view.rotated.plane[0].offset,
> vma->ggtt_view.rotated.plane[1].width,
> vma->ggtt_view.rotated.plane[1].height,
> - vma->ggtt_view.rotated.plane[1].stride,
> + vma->ggtt_view.rotated.plane[1].src_stride,
> vma->ggtt_view.rotated.plane[1].offset);
> break;
>
> @@ -188,11 +188,11 @@ i915_debugfs_describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
> seq_printf(m, ", remapped [(%ux%u, stride=%u, offset=%u), (%ux%u, stride=%u, offset=%u)]",
> vma->ggtt_view.remapped.plane[0].width,
> vma->ggtt_view.remapped.plane[0].height,
> - vma->ggtt_view.remapped.plane[0].stride,
> + vma->ggtt_view.remapped.plane[0].src_stride,
> vma->ggtt_view.remapped.plane[0].offset,
> vma->ggtt_view.remapped.plane[1].width,
> vma->ggtt_view.remapped.plane[1].height,
> - vma->ggtt_view.remapped.plane[1].stride,
> + vma->ggtt_view.remapped.plane[1].src_stride,
> vma->ggtt_view.remapped.plane[1].offset);
> break;
>
> diff --git a/drivers/gpu/drm/i915/i915_vma_types.h b/drivers/gpu/drm/i915/i915_vma_types.h
> index 358b4306fc00..f7f2aa168c9e 100644
> --- a/drivers/gpu/drm/i915/i915_vma_types.h
> +++ b/drivers/gpu/drm/i915/i915_vma_types.h
> @@ -100,7 +100,7 @@ struct intel_remapped_plane_info {
> u32 offset;
> u16 width;
> u16 height;
> - u16 stride;
> + u16 src_stride;
> u16 unused_mbz;
> } __packed;
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_vma.c b/drivers/gpu/drm/i915/selftests/i915_vma.c
> index 86c590b4522c..06f1827329d0 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_vma.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_vma.c
> @@ -361,7 +361,7 @@ static unsigned long rotated_index(const struct intel_rotation_info *r,
> unsigned int x,
> unsigned int y)
> {
> - return (r->plane[n].stride * (r->plane[n].height - y - 1) +
> + return (r->plane[n].src_stride * (r->plane[n].height - y - 1) +
> r->plane[n].offset + x);
> }
>
> @@ -411,7 +411,7 @@ static unsigned long remapped_index(const struct intel_remapped_info *r,
> unsigned int x,
> unsigned int y)
> {
> - return (r->plane[n].stride * y +
> + return (r->plane[n].src_stride * y +
> r->plane[n].offset + x);
> }
>
> @@ -479,21 +479,21 @@ static int igt_vma_rotate_remap(void *arg)
> struct i915_address_space *vm = &ggtt->vm;
> struct drm_i915_gem_object *obj;
> const struct intel_remapped_plane_info planes[] = {
> - { .width = 1, .height = 1, .stride = 1 },
> - { .width = 2, .height = 2, .stride = 2 },
> - { .width = 4, .height = 4, .stride = 4 },
> - { .width = 8, .height = 8, .stride = 8 },
> + { .width = 1, .height = 1, .src_stride = 1 },
> + { .width = 2, .height = 2, .src_stride = 2 },
> + { .width = 4, .height = 4, .src_stride = 4 },
> + { .width = 8, .height = 8, .src_stride = 8 },
>
> - { .width = 3, .height = 5, .stride = 3 },
> - { .width = 3, .height = 5, .stride = 4 },
> - { .width = 3, .height = 5, .stride = 5 },
> + { .width = 3, .height = 5, .src_stride = 3 },
> + { .width = 3, .height = 5, .src_stride = 4 },
> + { .width = 3, .height = 5, .src_stride = 5 },
>
> - { .width = 5, .height = 3, .stride = 5 },
> - { .width = 5, .height = 3, .stride = 7 },
> - { .width = 5, .height = 3, .stride = 9 },
> + { .width = 5, .height = 3, .src_stride = 5 },
> + { .width = 5, .height = 3, .src_stride = 7 },
> + { .width = 5, .height = 3, .src_stride = 9 },
>
> - { .width = 4, .height = 6, .stride = 6 },
> - { .width = 6, .height = 4, .stride = 6 },
> + { .width = 4, .height = 6, .src_stride = 6 },
> + { .width = 6, .height = 4, .src_stride = 6 },
> { }
> }, *a, *b;
> enum i915_ggtt_view_type types[] = {
> @@ -523,8 +523,8 @@ static int igt_vma_rotate_remap(void *arg)
> plane_info[0] = *a;
> plane_info[1] = *b;
>
> - max_offset = max(plane_info[0].stride * plane_info[0].height,
> - plane_info[1].stride * plane_info[1].height);
> + max_offset = max(plane_info[0].src_stride * plane_info[0].height,
> + plane_info[1].src_stride * plane_info[1].height);
> GEM_BUG_ON(max_offset > max_pages);
> max_offset = max_pages - max_offset;
>
> @@ -596,11 +596,11 @@ static int igt_vma_rotate_remap(void *arg)
> "rotated" : "remapped", n,
> plane_info[0].width,
> plane_info[0].height,
> - plane_info[0].stride,
> + plane_info[0].src_stride,
> plane_info[0].offset,
> plane_info[1].width,
> plane_info[1].height,
> - plane_info[1].stride,
> + plane_info[1].src_stride,
> plane_info[1].offset);
> err = -EINVAL;
> goto out_object;
> @@ -853,21 +853,21 @@ static int igt_vma_remapped_gtt(void *arg)
> {
> struct drm_i915_private *i915 = arg;
> const struct intel_remapped_plane_info planes[] = {
> - { .width = 1, .height = 1, .stride = 1 },
> - { .width = 2, .height = 2, .stride = 2 },
> - { .width = 4, .height = 4, .stride = 4 },
> - { .width = 8, .height = 8, .stride = 8 },
> + { .width = 1, .height = 1, .src_stride = 1 },
> + { .width = 2, .height = 2, .src_stride = 2 },
> + { .width = 4, .height = 4, .src_stride = 4 },
> + { .width = 8, .height = 8, .src_stride = 8 },
>
> - { .width = 3, .height = 5, .stride = 3 },
> - { .width = 3, .height = 5, .stride = 4 },
> - { .width = 3, .height = 5, .stride = 5 },
> + { .width = 3, .height = 5, .src_stride = 3 },
> + { .width = 3, .height = 5, .src_stride = 4 },
> + { .width = 3, .height = 5, .src_stride = 5 },
>
> - { .width = 5, .height = 3, .stride = 5 },
> - { .width = 5, .height = 3, .stride = 7 },
> - { .width = 5, .height = 3, .stride = 9 },
> + { .width = 5, .height = 3, .src_stride = 5 },
> + { .width = 5, .height = 3, .src_stride = 7 },
> + { .width = 5, .height = 3, .src_stride = 9 },
>
> - { .width = 4, .height = 6, .stride = 6 },
> - { .width = 6, .height = 4, .stride = 6 },
> + { .width = 4, .height = 6, .src_stride = 6 },
> + { .width = 6, .height = 4, .src_stride = 6 },
> { }
> }, *p;
> enum i915_ggtt_view_type types[] = {
> --
> 2.25.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-03-12 17:51 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 22:17 [Intel-gfx] [PATCH 00/23] drm/i915: Add support for FBs requiring a POT stride padding Imre Deak
2021-03-10 22:17 ` [Intel-gfx] [PATCH 01/23] drm/i915: Fix rotation setup during plane HW readout Imre Deak
2021-03-11 16:04 ` Ville Syrjälä
2021-03-11 16:52 ` Imre Deak
2021-03-11 17:25 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 02/23] drm/i915/selftest: Fix error handling in igt_vma_remapped_gtt() Imre Deak
2021-03-11 16:05 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 03/23] drm/i915/selftest: Fix debug message " Imre Deak
2021-03-11 16:06 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 04/23] drm/i915: Make sure i915_ggtt_view is inited when creating an FB Imre Deak
2021-03-11 16:07 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 05/23] drm/i915/selftest: Make sure to init i915_ggtt_view in igt_vma_rotate_remap() Imre Deak
2021-03-11 16:11 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 06/23] drm/i915: Remove duplicate intel_surf_alignment() declaration Imre Deak
2021-03-11 16:12 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 07/23] drm/i915/intel_fb: Pull FB plane functions from intel_display_types.h Imre Deak
2021-03-11 16:15 ` Ville Syrjälä
2021-03-11 16:31 ` Imre Deak
2021-03-10 22:17 ` [Intel-gfx] [PATCH 08/23] drm/i915/intel_fb: Pull FB plane functions from skl_universal_plane.c Imre Deak
2021-03-11 16:18 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 09/23] drm/i915/intel_fb: Pull is_surface_linear() from intel_display.c/skl_universal_plane.c Imre Deak
2021-03-11 16:19 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 10/23] drm/i915/intel_fb: Pull FB plane functions from intel_sprite.c Imre Deak
2021-03-11 16:20 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 11/23] drm/i915/intel_fb: Pull FB plane functions from intel_display.c Imre Deak
2021-03-11 16:23 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 12/23] drm/i915/intel_fb: Unexport intel_fb_check_stride() Imre Deak
2021-03-11 16:23 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 13/23] drm/i915/intel_fb: s/dev_priv/i915/ Imre Deak
2021-03-11 16:23 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 14/23] drm/i915/intel_fb: Factor out convert_plane_offset_to_xy() Imre Deak
2021-03-11 16:32 ` Ville Syrjälä
2021-03-11 16:37 ` Ville Syrjälä
2021-03-11 16:57 ` Imre Deak
2021-03-10 22:17 ` [Intel-gfx] [PATCH 15/23] drm/i915/intel_fb: Factor out calc_plane_aligned_offset() Imre Deak
2021-03-11 16:39 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 16/23] drm/i915/intel_fb: Factor out calc_plane_normal_size() Imre Deak
2021-03-11 16:52 ` Ville Syrjälä
2021-03-11 17:02 ` Imre Deak
2021-03-11 17:26 ` Ville Syrjälä
2021-03-11 17:47 ` Imre Deak
2021-03-11 17:58 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 17/23] drm/i915/intel_fb: Factor out plane_calc_remap_info() Imre Deak
2021-03-11 17:21 ` Ville Syrjälä
2021-03-11 19:04 ` Imre Deak
2021-03-11 19:35 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 18/23] drm/i915: Shrink the size of intel_remapped_plane_info struct Imre Deak
2021-03-11 19:45 ` Ville Syrjälä
2021-03-11 22:19 ` Imre Deak
2021-03-12 18:09 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 19/23] drm/i915/selftest: Unify use of intel_remapped_plane_info in igt_vma_rotate_remap() Imre Deak
2021-03-11 21:17 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 20/23] drm/i915: s/stride/src_stride/ in the intel_remapped_plane_info struct Imre Deak
2021-03-12 17:51 ` Ville Syrjälä [this message]
2021-03-10 22:17 ` [Intel-gfx] [PATCH 21/23] drm/i915: Add support for FBs requiring a POT stride alignment Imre Deak
2021-03-12 18:02 ` Ville Syrjälä
2021-03-13 14:36 ` Imre Deak
2021-03-15 14:44 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 22/23] drm/i915/selftest: Add remap/rotate vma subtests when dst_stride!=width/height Imre Deak
2021-03-12 18:03 ` Ville Syrjälä
2021-03-10 22:17 ` [Intel-gfx] [PATCH 23/23] drm/i915: For-CI: Force remapping the FB with a POT aligned stride Imre Deak
2021-03-10 23:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for FBs requiring a POT stride padding Patchwork
2021-03-10 23:54 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-03-11 0:22 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEuqJ0t+6gzW3Tcp@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox