From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
kernel-janitors@vger.kernel.org,
"David Airlie" <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
dri-devel@lists.freedesktop.org,
"Matthew Auld" <matthew.auld@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix an error code in intel_overlay_do_put_image()
Date: Tue, 20 Apr 2021 10:14:42 -0400 [thread overview]
Message-ID: <YH7h0jEiCcN2z5e8@intel.com> (raw)
In-Reply-To: <YHaFcEzcnh/hk1/Q@mwanda>
On Wed, Apr 14, 2021 at 09:02:24AM +0300, Dan Carpenter wrote:
> This code should propagate the error from intel_overlay_pin_fb()
> but currently it returns success.
>
> Fixes: 1b321026e213 ("drm/i915: Pass ww ctx to intel_pin_to_display_plane")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushed. thanks for the patch.
> ---
> drivers/gpu/drm/i915/display/intel_overlay.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
> index e477b6114a60..e5dadde422f7 100644
> --- a/drivers/gpu/drm/i915/display/intel_overlay.c
> +++ b/drivers/gpu/drm/i915/display/intel_overlay.c
> @@ -803,8 +803,10 @@ static int intel_overlay_do_put_image(struct intel_overlay *overlay,
> atomic_inc(&dev_priv->gpu_error.pending_fb_pin);
>
> vma = intel_overlay_pin_fb(new_bo);
> - if (IS_ERR(vma))
> + if (IS_ERR(vma)) {
> + ret = PTR_ERR(vma);
> goto out_pin_section;
> + }
>
> i915_gem_object_flush_frontbuffer(new_bo, ORIGIN_DIRTYFB);
>
> --
> 2.30.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-04-20 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 6:02 [Intel-gfx] [PATCH] drm/i915: fix an error code in intel_overlay_do_put_image() Dan Carpenter
2021-04-14 6:50 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-14 7:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-14 8:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-04-20 14:14 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH7h0jEiCcN2z5e8@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=matthew.auld@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox