Re: [Intel-gfx] [PATCH] drm/i915/gvt: remove local storage of debugfs file - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: remove local storage of debugfs file
Date: Wed, 19 May 2021 10:31:18 +0200	[thread overview]
Message-ID: <YKTM1tQ7SMPnYgiV@kroah.com> (raw)
In-Reply-To: <20210519080313.GH4589@zhen-hp.sh.intel.com>

On Wed, May 19, 2021 at 04:03:13PM +0800, Zhenyu Wang wrote:
> On 2021.05.18 18:28:53 +0200, Greg Kroah-Hartman wrote:
> > On Tue, May 18, 2021 at 06:17:05PM +0200, Greg Kroah-Hartman wrote:
> > > There is no need to keep the dentry around for the debugfs kvmgt cache
> > > file, as we can just look it up when we want to remove it later on.
> > > Simplify the structure by removing the dentry and relying on debugfs
> > > to find the dentry to remove when we want to.
> > > 
> > > By doing this change, we remove the last in-kernel user that was storing
> > > the result of debugfs_create_long(), so that api can be cleaned up.
> > > 
> > > Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> > > Cc: Zhi Wang <zhi.a.wang@intel.com>
> > > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > > Cc: David Airlie <airlied@linux.ie>
> > > Cc: Daniel Vetter <daniel@ffwll.ch>
> > > Cc: intel-gvt-dev@lists.freedesktop.org
> > > Cc: intel-gfx@lists.freedesktop.org
> > > Cc: dri-devel@lists.freedesktop.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > >  drivers/gpu/drm/i915/gvt/kvmgt.c | 11 +++++------
> > >  1 file changed, 5 insertions(+), 6 deletions(-)
> > 
> > Note, I can take this through my debugfs tree if wanted, that way I can
> > clean up the debugfs_create_long() api at the same time.  Otherwise it's
> > fine, I can wait until next -rc1 for that to happen.
> > 
> 
> It's fine with me to go through debugfs tree. Just double check that recent
> kvmgt change would not cause conflict with this as well.

How can I check that?  I'll be glad to take this through my tree, we can
handle the merge issues later for 5.14-rc1 :)

thanks,

greg k-h
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx