From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Vidya Srinivas <vidya.srinivas@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
charlton.lin@intel.com
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms
Date: Mon, 31 May 2021 17:17:33 +0300 [thread overview]
Message-ID: <YLTv/Z8j9rCf2koN@intel.com> (raw)
In-Reply-To: <1622176443-12682-1-git-send-email-vidya.srinivas@intel.com>
On Fri, May 28, 2021 at 10:04:03AM +0530, Vidya Srinivas wrote:
> For Intel platforms, pitch needs to be 64 byte aligned.
> Kernel code vgem_gem_dumb_create which is platform generic code
> doesnt do the alignment. This causes frame buffer creation to fail
> on Intel platforms where the pitch is not 64 byte aligned.
>
> tests: test run on Intel platforms with panel resolution 1366x768
>
> Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
> ---
> tests/kms_prime.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_prime.c b/tests/kms_prime.c
> index 8cb2ca2a9dc3..fdc941fe8100 100644
> --- a/tests/kms_prime.c
> +++ b/tests/kms_prime.c
> @@ -51,6 +51,8 @@ static struct {
> { .r = 1.0, .g = 0.0, .b = 0.0, .color = 0xffff0000 },
> };
>
> +bool check_platform;
> +
> IGT_TEST_DESCRIPTION("Prime tests, focusing on KMS side");
>
> static bool has_prime_import(int fd)
> @@ -101,7 +103,7 @@ static void prepare_scratch(int exporter_fd, struct dumb_bo *scratch,
> scratch->bpp = 32;
>
> scratch->handle = kmstest_dumb_create(exporter_fd,
> - scratch->width,
> + check_platform? ALIGN(scratch->width, 64): scratch->width,
The dumb_create ioctl already does this for us.
> scratch->height,
> scratch->bpp,
> &scratch->pitch,
> @@ -262,6 +264,7 @@ igt_main
>
> /* ANY = anything that is not VGEM */
> first_fd = __drm_open_driver_another(0, DRIVER_ANY | DRIVER_VGEM);
> + check_platform = is_i915_device(first_fd);
> igt_require(first_fd >= 0);
>
> second_fd = __drm_open_driver_another(1, DRIVER_ANY | DRIVER_VGEM);
> --
> 2.7.4
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-05-31 14:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 4:34 [Intel-gfx] [PATCH i-g-t] [RFC] tests/kms_prime: Aligned pitch to 64 byte for Intel platforms Vidya Srinivas
2021-05-31 14:17 ` Ville Syrjälä [this message]
2021-05-31 14:47 ` [Intel-gfx] [igt-dev] " Srinivas, Vidya
2021-06-04 18:54 ` Mark Yacoub
2021-06-05 5:44 ` Srinivas, Vidya
2021-06-11 7:35 ` Srinivas, Vidya
2021-06-28 11:08 ` Surendrakumar Upadhyay, TejaskumarX
2021-07-13 17:14 ` Srinivas, Vidya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLTv/Z8j9rCf2koN@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=charlton.lin@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=vidya.srinivas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox