Re: [Intel-gfx] [PATCH] drm/i915/gem/ttm: prefer kernel types

[Daniel Vetter <daniel@ffwll.ch>]

On Tue, Aug 10, 2021 at 11:41:28AM +0300, Jani Nikula wrote:
> Avoid uintXX_t types in the driver.
> 
> Fixes: 213d50927763 ("drm/i915/ttm: Introduce a TTM i915 gem object backend")
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index 771eb2963123..ffda88156e32 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -168,7 +168,7 @@ i915_ttm_placement_from_obj(const struct drm_i915_gem_object *obj,
>  }
>  
>  static struct ttm_tt *i915_ttm_tt_create(struct ttm_buffer_object *bo,
> -					 uint32_t page_flags)
> +					 u32 page_flags)

It's for the ttm_device_funcs ops table, I thinhk we should fix it there
and across the board?

Otherwise a bit ocd mismatch :-)
-Daniel

>  {
>  	struct ttm_resource_manager *man =
>  		ttm_manager_type(bo->bdev, bo->resource->mem_type);
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch