From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, ville.syrjala@linux.intel.com,
daniel@ffwll.ch
Subject: Re: [Intel-gfx] [PATCH 0/6] drm/i915/display: split out some dpt and fb stuff from intel_display.c
Date: Tue, 24 Aug 2021 07:59:36 -0400 [thread overview]
Message-ID: <YSTfKKa1Zkr6o4l+@intel.com> (raw)
In-Reply-To: <cover.1629721467.git.jani.nikula@intel.com>
On Mon, Aug 23, 2021 at 03:25:30PM +0300, Jani Nikula wrote:
> Make some forward progress on reducing intel_display.c size.
>
> Jani Nikula (6):
> drm/i915/display: split out dpt out of intel_display.c
> drm/i915: add HAS_ASYNC_FLIPS feature macro
> drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c
> drm/i915/fb: move intel_fb_align_height() to intel_fb.c
> drm/i915/fb: move intel_surf_alignment() to intel_fb.c
> drm/i915/fb: move user framebuffer stuff to intel_fb.c
>
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/display/intel_display.c | 709 +------------------
> drivers/gpu/drm/i915/display/intel_display.h | 6 -
> drivers/gpu/drm/i915/display/intel_dpt.c | 229 ++++++
> drivers/gpu/drm/i915/display/intel_dpt.h | 19 +
> drivers/gpu/drm/i915/display/intel_fb.c | 481 +++++++++++++
> drivers/gpu/drm/i915/display/intel_fb.h | 20 +-
> drivers/gpu/drm/i915/display/intel_fbdev.c | 1 +
> drivers/gpu/drm/i915/i915_drv.h | 2 +
> 9 files changed, 752 insertions(+), 716 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.c
> create mode 100644 drivers/gpu/drm/i915/display/intel_dpt.h
I believe it would be good to add a /** DOC: */ or at least
a simple comment block explaining a bit what DPT is.
But other than that the series looks good, so, up to you:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
(for the series)
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-08-24 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 12:25 [Intel-gfx] [PATCH 0/6] drm/i915/display: split out some dpt and fb stuff from intel_display.c Jani Nikula
2021-08-23 12:25 ` [Intel-gfx] [PATCH 1/6] drm/i915/display: split out dpt out of intel_display.c Jani Nikula
2021-08-23 12:25 ` [Intel-gfx] [PATCH 2/6] drm/i915: add HAS_ASYNC_FLIPS feature macro Jani Nikula
2021-08-23 12:25 ` [Intel-gfx] [PATCH 3/6] drm/i915/fb: move intel_tile_width_bytes() to intel_fb.c Jani Nikula
2021-08-23 12:25 ` [Intel-gfx] [PATCH 4/6] drm/i915/fb: move intel_fb_align_height() " Jani Nikula
2021-08-23 12:25 ` [Intel-gfx] [PATCH 5/6] drm/i915/fb: move intel_surf_alignment() " Jani Nikula
2021-08-23 12:25 ` [Intel-gfx] [PATCH 6/6] drm/i915/fb: move user framebuffer stuff " Jani Nikula
2021-08-23 12:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: split out some dpt and fb stuff from intel_display.c Patchwork
2021-08-23 12:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-08-23 13:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-23 15:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-08-24 11:59 ` Rodrigo Vivi [this message]
2021-08-24 13:25 ` [Intel-gfx] [PATCH 0/6] " Jani Nikula
2021-08-24 18:03 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSTfKKa1Zkr6o4l+@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox