From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/fdi: make intel_fdi_link_freq() return int
Date: Tue, 24 Aug 2021 19:09:58 +0300 [thread overview]
Message-ID: <YSUZ1keUjJJk4yy4@intel.com> (raw)
In-Reply-To: <20210823093645.10464-1-jani.nikula@intel.com>
On Mon, Aug 23, 2021 at 12:36:45PM +0300, Jani Nikula wrote:
> The unsigned doesn't help us here.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_fdi.c | 2 +-
> drivers/gpu/drm/i915/display/intel_fdi.h | 4 +---
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c
> index 970a57369b05..13f8ba4c9188 100644
> --- a/drivers/gpu/drm/i915/display/intel_fdi.c
> +++ b/drivers/gpu/drm/i915/display/intel_fdi.c
> @@ -95,7 +95,7 @@ static int ilk_check_fdi_lanes(struct drm_device *dev, enum pipe pipe,
> }
> }
>
> -u32 intel_fdi_link_freq(struct drm_i915_private *i915,
> +int intel_fdi_link_freq(struct drm_i915_private *i915,
> const struct intel_crtc_state *pipe_config)
> {
> if (HAS_DDI(i915))
> diff --git a/drivers/gpu/drm/i915/display/intel_fdi.h b/drivers/gpu/drm/i915/display/intel_fdi.h
> index fd63a6a53fca..2c8ffd9ceaed 100644
> --- a/drivers/gpu/drm/i915/display/intel_fdi.h
> +++ b/drivers/gpu/drm/i915/display/intel_fdi.h
> @@ -6,15 +6,13 @@
> #ifndef _INTEL_FDI_H_
> #define _INTEL_FDI_H_
>
> -#include <linux/types.h>
> -
> struct drm_i915_private;
> struct intel_crtc;
> struct intel_crtc_state;
> struct intel_encoder;
>
> #define I915_DISPLAY_CONFIG_RETRY 1
> -u32 intel_fdi_link_freq(struct drm_i915_private *i915,
> +int intel_fdi_link_freq(struct drm_i915_private *i915,
> const struct intel_crtc_state *pipe_config);
> int ilk_fdi_compute_config(struct intel_crtc *intel_crtc,
> struct intel_crtc_state *pipe_config);
> --
> 2.20.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-08-24 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 9:36 [Intel-gfx] [PATCH] drm/i915/fdi: make intel_fdi_link_freq() return int Jani Nikula
2021-08-23 10:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-08-23 11:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-08-24 16:09 ` Ville Syrjälä [this message]
2021-08-24 16:27 ` [Intel-gfx] [PATCH] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSUZ1keUjJJk4yy4@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox