From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "daniel@ffwll.ch" <daniel@ffwll.ch>,
"Mun, Gwan-gyeong" <gwan-gyeong.mun@intel.com>,
"Nikula, Jani" <jani.nikula@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 7/8] drm/i915/display/skl+: Drop frontbuffer rendering support
Date: Wed, 25 Aug 2021 15:47:12 +0300 [thread overview]
Message-ID: <YSY70P8JCDsJotvl@intel.com> (raw)
In-Reply-To: <e1ac87ec1939ab763b924a3f70f79bdfef14b77d.camel@intel.com>
On Wed, Aug 25, 2021 at 12:49:25AM +0000, Souza, Jose wrote:
> On Thu, 2021-08-19 at 19:07 +0300, Ville Syrjälä wrote:
> > On Wed, Aug 18, 2021 at 07:48:03PM +0000, Souza, Jose wrote:
> > > On Wed, 2021-08-18 at 17:55 +0300, Ville Syrjälä wrote:
> > > > On Tue, Aug 17, 2021 at 05:42:15PM -0700, José Roberto de Souza wrote:
> > > > > By now all the userspace applications should have migrated to atomic
> > > > > or at least be calling DRM_IOCTL_MODE_DIRTYFB.
> > > > >
> > > > > With that we can kill frontbuffer rendering support in i915 for
> > > > > modern platforms.
> > > > >
> > > > > So here converting legacy APIs into atomic commits so it can be
> > > > > properly handled by driver i915.
> > > > >
> > > > > Several IGT tests will fail with this changes, because some tests
> > > > > were stressing those frontbuffer rendering scenarios that no userspace
> > > > > should be using by now, fixes to IGT should be sent soon.
> > > >
> > > > Blocking atomic commits instead of the current lightweight frontbuffer
> > > > interface sounds like a terrible plan. How unusable is X with this
> > > > approach?
> > >
> > > 100% usable, had no issues when running X in TGL and ADL-P.
> > > Added a debug message in intel_user_framebuffer_dirty() and X is not even using frontbuffer rendering at all.
> >
> > Turn off your compositor if you want to test front buffer rendering.
>
> Worked fine on Plasma with a 4K panel, was not able to find how to do that in Gnome.
I didn't think you can turn off composition with either one of those.
You actually confirmed it's running with everytithing unredirected and
eg. there was no lag moving windows around and wiggling the mouse?
Avoiding that lag is pretty much the sole reason why the legacy
cursor unsynced update stuff even exists in the driver. Hard to
imagine you wouldn't hit the same issue with the server getting
blocked on dirtyfb all the time.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-08-25 12:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 0:42 [Intel-gfx] [PATCH 0/8] Drop frontbuffer rendering support from Skylake and newer José Roberto de Souza
2021-08-18 0:42 ` [Intel-gfx] [PATCH 1/8] drm/damage_helper: Fix handling of cursor dirty buffers José Roberto de Souza
2021-08-18 0:42 ` [Intel-gfx] [PATCH 2/8] drm/i915/display: Drop PSR support from HSW and BDW José Roberto de Souza
2021-08-18 0:42 ` [Intel-gfx] [PATCH 3/8] drm/i915/display: Move DRRS code its own file José Roberto de Souza
2021-08-18 7:24 ` Jani Nikula
2021-08-19 0:44 ` Souza, Jose
2021-08-18 0:42 ` [Intel-gfx] [PATCH 4/8] drm/i915/display: Some code improvements and code style fixes for DRRS José Roberto de Souza
2021-08-18 0:42 ` [Intel-gfx] [PATCH 5/8] drm/i915/display: Share code between intel_edp_drrs_flush and invalidate José Roberto de Souza
2021-08-18 0:42 ` [Intel-gfx] [PATCH 6/8] drm/i915/display: Prepare DRRS for frontbuffer rendering drop José Roberto de Souza
2021-08-18 0:42 ` [Intel-gfx] [PATCH 7/8] drm/i915/display/skl+: Drop frontbuffer rendering support José Roberto de Souza
2021-08-18 14:55 ` Ville Syrjälä
2021-08-18 19:48 ` Souza, Jose
2021-08-19 16:07 ` Ville Syrjälä
2021-08-25 0:49 ` Souza, Jose
2021-08-25 12:47 ` Ville Syrjälä [this message]
2021-08-25 13:43 ` Ville Syrjälä
2021-08-26 1:23 ` Souza, Jose
2021-08-24 7:21 ` Daniel Vetter
2021-08-18 0:42 ` [Intel-gfx] [PATCH 8/8] drm/i915/display: Drop PSR " José Roberto de Souza
2021-08-18 1:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Drop frontbuffer rendering support from Skylake and newer Patchwork
2021-08-18 1:14 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-08-18 1:45 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSY70P8JCDsJotvl@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=gwan-gyeong.mun@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jose.souza@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox