From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, uma.shankar@intel.com,
jani.nikula@intel.com
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/display: program audio CDCLK-TS for keepalives
Date: Wed, 6 Oct 2021 19:56:05 +0300 [thread overview]
Message-ID: <YV3VJWPAhi553eXs@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2110061844070.3554566@eliteleevi.tm.intel.com>
On Wed, Oct 06, 2021 at 06:45:31PM +0300, Kai Vehmanen wrote:
> Hi,
>
> On Wed, 6 Oct 2021, Ville Syrjälä wrote:
>
> > On Mon, Sep 13, 2021 at 07:40:04PM +0300, Kai Vehmanen wrote:
> > > XE_LPD display adds support for display audio codec keepalive feature.
> > > This feature works also when display codec is in D3 state and the audio
> > > link is off (BCLK off). To enable this functionality, display driver
> > > must update the AUD_TS_CDCLK_M/N registers whenever CDCLK is changed.
> > > Actual timestamps are generated only when the audio codec driver
> > > specifically enables the KeepAlive (KAE) feature.
> [...]
> > > + if (refclk == 24000)
> > > + aud_ts->m = 12;
> >
> > Wasn't there a single exception to this rule? Ie. should this be
> > if (refclk == 24000 && cdclk != something) ?
>
> ack. I had a discussion with hw folks on this and concluded we can go
> with the simple formula.
OK. Seems fine by me.
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2021-10-06 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 16:40 [Intel-gfx] [PATCH v2] drm/i915/display: program audio CDCLK-TS for keepalives Kai Vehmanen
2021-09-13 18:06 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: program audio CDCLK-TS for keepalives (rev2) Patchwork
2021-09-15 19:55 ` [Intel-gfx] [PATCH v2] drm/i915/display: program audio CDCLK-TS for keepalives Shankar, Uma
2021-09-21 12:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: program audio CDCLK-TS for keepalives (rev3) Patchwork
2021-09-21 15:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-06 13:49 ` [Intel-gfx] [PATCH v2] drm/i915/display: program audio CDCLK-TS for keepalives Ville Syrjälä
2021-10-06 15:45 ` Kai Vehmanen
2021-10-06 16:56 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV3VJWPAhi553eXs@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox