From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 0/1] drm/i915: vlv sideband
Date: Wed, 13 Oct 2021 13:59:03 +0300 [thread overview]
Message-ID: <YWa79w8LWIi3tpcn@intel.com> (raw)
In-Reply-To: <87sfx5xkuq.fsf@intel.com>
On Wed, Oct 13, 2021 at 01:47:09PM +0300, Jani Nikula wrote:
> On Wed, 13 Oct 2021, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Wed, Oct 13, 2021 at 01:11:58PM +0300, Jani Nikula wrote:
> >> Three main ideas here:
> >>
> >> - vlv sideband only has the name "sideband" in common with the rest of
> >> intel_sideband.[ch]
> >
> > I wouldn't put it like that. There are two actual sideband
> > implementtions in that file:
> > - vlv/chv iosf sideband (vlv_sideband)
> > - lpt/wpt iosf sideband (intel_sbi)
> >
> > And the third thing in that file is the snb+ pcode mailbox stuff,
> > which has nothing to do with sideband.
>
> Fair enough... but no opposition to the splitting out of vlv/chv iosf
> sideband? vlv_sideband.[ch] like here? I'm fine with renaming too.
>
> I can follow up with lpt/wpt iosf split out (intel_sbi.[ch]?) and snb+
> pcode (intel_pcode.[ch]?).
Yeah, I guess just full split is the cleanest. Those names seem OK
to me. Or I suppose we could rename the intel_sbi stuff to lpt_sbi
or something? Might not be worth the hassle. Adding a small comment
to intel_sbi.c to document what it's for should be sufficient reminder.
> I think we've just put all of them together way back when this was all
> probably bundled in i915_drv.c or something...
Yeah. I think the common thread was that you need to go through
a mailbox, but the file name didn't really reflect that.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-10-13 10:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 10:11 [Intel-gfx] [PATCH 0/1] drm/i915: vlv sideband Jani Nikula
2021-10-13 10:11 ` [Intel-gfx] [PATCH 1/1] drm/i915: split out vlv sideband to a separate file Jani Nikula
2021-10-13 11:55 ` Hans de Goede
2021-10-13 15:51 ` Lucas De Marchi
2021-10-13 10:28 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: vlv sideband Patchwork
2021-10-13 10:38 ` [Intel-gfx] [PATCH 0/1] " Ville Syrjälä
2021-10-13 10:47 ` Jani Nikula
2021-10-13 10:59 ` Ville Syrjälä [this message]
2021-10-13 15:47 ` Lucas De Marchi
2021-10-13 10:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-10-13 13:13 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWa79w8LWIi3tpcn@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox