From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, airlied@gmail.com,
daniel@ffwll.ch, lucas.demarchi@intel.com,
Dave Airlie <airlied@redhat.com>
Subject: Re: [Intel-gfx] [PATCH 3/4] drm/i915/audio: define the audio struct separately from drm_i915_private
Date: Fri, 22 Oct 2021 19:44:37 +0300 [thread overview]
Message-ID: <YXLqdUaSHlfIPpN2@intel.com> (raw)
In-Reply-To: <97098cf69dfeb0c6c4ab85d3378e4d41fdd952c2.1634918767.git.jani.nikula@intel.com>
On Fri, Oct 22, 2021 at 07:27:57PM +0300, Jani Nikula wrote:
> Add a standalone definition of struct intel_audio_private, and note that
> all of it is private to intel_audio.c.
>
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 45 ++++++++++++++++++---------------
> 1 file changed, 24 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 9c77610acf23..ed86633a587b 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -828,6 +828,29 @@ struct i915_selftest_stash {
> struct ida mock_region_instances;
> };
>
> +/* intel_audio.c private */
> +struct intel_audio_private {
Not sure the "_private" is actually useful. I'd just call it
intel_audio. The fact that struct drm_i915_private
already says "private" doesn't mean anything to anyone anyway.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-10-22 16:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 16:27 [Intel-gfx] [PATCH 0/4] drm/i915: split out audio private from dev_priv Jani Nikula
2021-10-22 16:27 ` [Intel-gfx] [PATCH 1/4] drm/i915/audio: group audio under anonymous struct in drm_i915_private Jani Nikula
2021-10-22 17:22 ` Lucas De Marchi
2021-10-28 17:36 ` Jani Nikula
2021-10-22 16:27 ` [Intel-gfx] [PATCH 2/4] drm/i915/audio: name the audio sub-struct " Jani Nikula
2021-10-22 16:42 ` Ville Syrjälä
2021-10-22 16:58 ` Jani Nikula
2021-10-22 16:27 ` [Intel-gfx] [PATCH 3/4] drm/i915/audio: define the audio struct separately from drm_i915_private Jani Nikula
2021-10-22 16:44 ` Ville Syrjälä [this message]
2021-10-22 17:07 ` Jani Nikula
2021-10-28 17:37 ` Jani Nikula
2021-10-22 16:27 ` [Intel-gfx] [PATCH 4/4] drm/i915/audio: move intel_audio_funcs internal to intel_audio.c Jani Nikula
2021-10-22 16:48 ` Ville Syrjälä
2021-10-22 17:29 ` [Intel-gfx] [PATCH 0/4] drm/i915: split out audio private from dev_priv Lucas De Marchi
2021-10-22 20:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-10-22 21:10 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-23 4:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXLqdUaSHlfIPpN2@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox