Re: [Intel-gfx] [PATCH 1/1] drm/i915/rpm: Enable runtime pm autosuspend by default

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Nov 10, 2021 at 01:46:46PM +0200, Ville Syrjälä wrote:
> On Wed, Nov 10, 2021 at 10:59:26AM +0530, Tilak Tangudu wrote:
> > Enable runtime pm autosuspend by default for gen12 and
> > later versions.
> > 
> > Signed-off-by: Tilak Tangudu <tilak.tangudu@intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > index eaf7688f517d..ef75f24288ef 100644
> > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> > @@ -600,6 +600,10 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)
> >  		pm_runtime_use_autosuspend(kdev);
> >  	}
> >  
> > +	/* XXX: Enable by default only for newer platforms for now */
> > +	if (GRAPHICS_VER(i915) >= 12)
> > +		pm_runtime_allow(kdev);
> 
> If we change some default then we should just do it across the board.
> There is nothing special about tgl+.

Nothing special with tgl and newer platforms indeed. This is why we
have the XXX message here.

The problem in the last attempt was with the gen9 platforms.
Apparently some special there, and I didn't want to block the
progress while we cannot get to the gen9 bugs.

> 
> > +
> >  	/*
> >  	 * The core calls the driver load handler with an RPM reference held.
> >  	 * We drop that here and will reacquire it during unloading in
> > -- 
> > 2.25.1
> 
> -- 
> Ville Syrjälä
> Intel