Re: [Intel-gfx] [PATCH 4/4] drm/i915/dsi: split out icl_dsi.h

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, Nov 22, 2021 at 01:15:04PM +0200, Jani Nikula wrote:
> Follow the convention of corresponding .h for .c.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

for the series

> ---
>  drivers/gpu/drm/i915/display/icl_dsi.c       |  1 +
>  drivers/gpu/drm/i915/display/icl_dsi.h       | 15 +++++++++++++++
>  drivers/gpu/drm/i915/display/intel_crtc.c    |  2 +-
>  drivers/gpu/drm/i915/display/intel_display.c |  1 +
>  drivers/gpu/drm/i915/display/intel_dsi.h     |  5 -----
>  5 files changed, 18 insertions(+), 6 deletions(-)
>  create mode 100644 drivers/gpu/drm/i915/display/icl_dsi.h
> 
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index 2f15b322d78f..5781e9fac8b4 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -28,6 +28,7 @@
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_mipi_dsi.h>
>  
> +#include "icl_dsi.h"
>  #include "intel_atomic.h"
>  #include "intel_backlight.h"
>  #include "intel_combo_phy.h"
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.h b/drivers/gpu/drm/i915/display/icl_dsi.h
> new file mode 100644
> index 000000000000..b4861b56b5b2
> --- /dev/null
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2021 Intel Corporation
> + */
> +
> +#ifndef __ICL_DSI_H__
> +#define __ICL_DSI_H__
> +
> +struct drm_i915_private;
> +struct intel_crtc_state;
> +
> +void icl_dsi_init(struct drm_i915_private *i915);
> +void icl_dsi_frame_update(struct intel_crtc_state *crtc_state);
> +
> +#endif /* __ICL_DSI_H__ */
> diff --git a/drivers/gpu/drm/i915/display/intel_crtc.c b/drivers/gpu/drm/i915/display/intel_crtc.c
> index eb5444f90e77..243d5cc29734 100644
> --- a/drivers/gpu/drm/i915/display/intel_crtc.c
> +++ b/drivers/gpu/drm/i915/display/intel_crtc.c
> @@ -14,7 +14,7 @@
>  
>  #include "i915_trace.h"
>  #include "i915_vgpu.h"
> -
> +#include "icl_dsi.h"
>  #include "intel_atomic.h"
>  #include "intel_atomic_plane.h"
>  #include "intel_color.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 2ffed63dd498..b2d51cd79d6c 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -73,6 +73,7 @@
>  #include "g4x_dp.h"
>  #include "g4x_hdmi.h"
>  #include "i915_drv.h"
> +#include "icl_dsi.h"
>  #include "intel_acpi.h"
>  #include "intel_atomic.h"
>  #include "intel_atomic_plane.h"
> diff --git a/drivers/gpu/drm/i915/display/intel_dsi.h b/drivers/gpu/drm/i915/display/intel_dsi.h
> index dd913ad35232..a3a906cb097e 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsi.h
> +++ b/drivers/gpu/drm/i915/display/intel_dsi.h
> @@ -166,11 +166,6 @@ static inline u16 intel_dsi_encoder_ports(struct intel_encoder *encoder)
>  	return enc_to_intel_dsi(encoder)->ports;
>  }
>  
> -/* icl_dsi.c */
> -void icl_dsi_init(struct drm_i915_private *dev_priv);
> -void icl_dsi_frame_update(struct intel_crtc_state *crtc_state);
> -
> -/* intel_dsi.c */
>  int intel_dsi_bitrate(const struct intel_dsi *intel_dsi);
>  int intel_dsi_tlpx_ns(const struct intel_dsi *intel_dsi);
>  enum drm_panel_orientation
> -- 
> 2.30.2
>