From: Andi Shyti <andi.shyti@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org, "Vudum,
Lakshminarayana" <lakshminarayana.vudum@intel.com>
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for More preparation for multi gt patches
Date: Sat, 18 Dec 2021 16:02:08 +0200 [thread overview]
Message-ID: <Yb3p4JoEmqJkb8sV@intel.intel> (raw)
In-Reply-To: <Yb17iflI3R8xFtMW@mdroper-desk1.amr.corp.intel.com>
Hi Matt,
> The first 10 patches have gone through several clean CI cycles now, so
> I've pushed those to drm-intel-gt-next. There are just a couple minor
> comments on the ggtt patches, so we can push the rest of those once the
> comments are addressed.
>
> BTW, there's one i915->gt reference in the display code that has moved
> from display/intel_display.c to display/skl_universal_plane.c on
> drm-intel-next, but that movement hasn't made its way to
> drm-intel-gt-next yet. This led to a merge conflict while rebuilding
> drm-tip. I had to use a 'dim cat-to-fixup' to apply the following diff
> to the drm-intel-gt-next merge commit:
>
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 158d89b8d490..b3162f49f341 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -1737,7 +1737,7 @@ static bool bo_has_valid_encryption(struct drm_i915_gem_object *obj)
> {
> struct drm_i915_private *i915 = to_i915(obj->base.dev);
>
> - return intel_pxp_key_check(&i915->gt.pxp, obj, false) == 0;
> + return intel_pxp_key_check(&to_gt(i915)->pxp, obj, false) == 0;
> }
>
> static bool pxp_is_borked(struct drm_i915_gem_object *obj)
thanks for pointing this out.
Andi
next prev parent reply other threads:[~2021-12-18 14:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 19:33 [Intel-gfx] [PATCH v8 00/16] More preparation for multi gt patches Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 01/16] drm/i915: Store backpointer to GT in uncore Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 02/16] drm/i915: Introduce to_gt() helper Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 03/16] drm/i915/display: Use " Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 04/16] drm/i915/gt: " Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 05/16] drm/i915/gem: " Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 06/16] drm/i915/gvt: " Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 07/16] drm/i915/selftests: " Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 08/16] drm/i915/pxp: " Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 09/16] drm/i915: " Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 10/16] drm/i915: Rename i915->gt to i915->gt0 Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 11/16] drm/i915/gem: Use to_gt() helper for GGTT accesses Andi Shyti
2021-12-17 0:41 ` Sundaresan, Sujaritha
2021-12-18 4:44 ` Matt Roper
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 12/16] drm/i915/display: " Andi Shyti
2021-12-16 23:13 ` Sundaresan, Sujaritha
2021-12-18 4:45 ` Matt Roper
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 13/16] drm/i915/gt: " Andi Shyti
2021-12-16 23:12 ` Sundaresan, Sujaritha
2021-12-18 4:46 ` Matt Roper
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 14/16] drm/i915/selftests: " Andi Shyti
2021-12-16 23:11 ` Sundaresan, Sujaritha
2021-12-18 4:49 ` Matt Roper
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 15/16] drm/i915: " Andi Shyti
2021-12-18 4:54 ` Matt Roper
2021-12-18 13:49 ` Andi Shyti
2021-12-14 19:33 ` [Intel-gfx] [PATCH v8 16/16] drm/i915: Remove unused i915->ggtt Andi Shyti
2021-12-16 21:26 ` Sundaresan, Sujaritha
2021-12-18 5:05 ` Matt Roper
2021-12-14 19:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More preparation for multi gt patches Patchwork
2021-12-14 19:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-12-14 20:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-12-15 7:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-18 6:11 ` Matt Roper
2021-12-18 14:02 ` Andi Shyti [this message]
2021-12-20 4:03 ` Vudum, Lakshminarayana
2021-12-17 10:12 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for More preparation for multi gt patches (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yb3p4JoEmqJkb8sV@intel.intel \
--to=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lakshminarayana.vudum@intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox