From: Daniel Vetter <daniel@ffwll.ch>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
Zheyu Ma <zheyuma97@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
Xiyu Yang <xiyuyang19@fudan.edu.cn>,
Jens Frederich <jfrederich@gmail.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
linux-staging@lists.linux.dev,
LKML <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Zhen Lei <thunder.leizhen@huawei.com>,
Matthew Wilcox <willy@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alex Deucher <alexander.deucher@amd.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
Helge Deller <deller@gmx.de>
Subject: Re: [Intel-gfx] [PATCH 21/21] fbdev: Make registered_fb[] private to fbmem.c
Date: Tue, 8 Feb 2022 15:04:51 +0100 [thread overview]
Message-ID: <YgJ4g2BEaeUELmvF@phenom.ffwll.local> (raw)
In-Reply-To: <CAMuHMdUm76tT6u+i=A50ffh=k8hX5kgoMqH=t_wfHqH95nVOPA@mail.gmail.com>
On Fri, Feb 04, 2022 at 09:30:56AM +0100, Geert Uytterhoeven wrote:
> Hi Daniel,
>
> Thanks for your patch!
>
> On Tue, Feb 1, 2022 at 9:50 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> > Well except when the olpc dcon fbdev driver is enabled, that thing
> > digs around in there in rather unfixable ways.
>
> Can't the actual frame buffer driver (which one?) used on olpc export
> a pointer to its fb_info?
Yeah that might be the right thing to do, I'll add that as a stagin TODO
in the next iteration.
>
> > --- a/drivers/video/fbdev/core/fbmem.c
> > +++ b/drivers/video/fbdev/core/fbmem.c
> > @@ -48,10 +48,14 @@
> > static DEFINE_MUTEX(registration_lock);
> >
> > struct fb_info *registered_fb[FB_MAX] __read_mostly;
> > -EXPORT_SYMBOL(registered_fb);
> > -
> > int num_registered_fb __read_mostly;
> > +#if IS_ENABLED(CONFIG_OLPC_DCON)
>
> CONFIG_FB_OLPC_DCON (everywhere), cfr. the build failure reported
> by the robot.
Yeah realized that too and fixed it locally.
Cheers, Daniel
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2022-02-08 14:04 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 21:05 [Intel-gfx] [PATCH 00/21] some fbcon patches, mostly locking Daniel Vetter
2022-01-31 21:05 ` [Intel-gfx] [PATCH 01/21] MAINTAINERS: Add entry for fbdev core Daniel Vetter
2022-02-01 10:19 ` Thomas Zimmermann
2022-02-01 10:45 ` Greg Kroah-Hartman
2022-02-01 10:32 ` Helge Deller
2022-02-01 14:01 ` Javier Martinez Canillas
2022-02-01 14:47 ` Jani Nikula
2022-02-01 14:54 ` Geert Uytterhoeven
2022-02-01 20:47 ` Dave Airlie
2022-02-02 11:10 ` Daniel Stone
2022-02-02 11:18 ` Tomi Valkeinen
2022-02-02 11:31 ` Maxime Ripard
2022-02-02 13:48 ` Alex Deucher
2022-02-03 20:25 ` Sam Ravnborg
2022-02-08 14:12 ` Daniel Vetter
2022-01-31 21:05 ` [Intel-gfx] [PATCH 02/21] fbcon: Resurrect fbcon accelerated scrolling code Daniel Vetter
2022-01-31 21:05 ` [Intel-gfx] [PATCH 03/21] fbcon: Restore fbcon scrolling acceleration Daniel Vetter
2022-02-01 10:16 ` Helge Deller
2022-02-01 10:17 ` Helge Deller
2022-02-01 10:36 ` Daniel Vetter
2022-02-01 11:01 ` Helge Deller
2022-02-01 13:45 ` Daniel Vetter
2022-02-01 14:52 ` Helge Deller
2022-02-01 16:30 ` Daniel Vetter
2022-01-31 21:05 ` [Intel-gfx] [PATCH 04/21] fbcon: delete a few unneeded forward decl Daniel Vetter
2022-02-03 20:30 ` Sam Ravnborg
2022-02-04 10:00 ` Geert Uytterhoeven
2022-01-31 21:05 ` [Intel-gfx] [PATCH 05/21] fbcon: Introduce wrapper for console->fb_info lookup Daniel Vetter
2022-02-03 21:25 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 06/21] fbcon: delete delayed loading code Daniel Vetter
2022-02-03 20:45 ` Sam Ravnborg
2022-02-08 13:42 ` Daniel Vetter
2022-02-08 18:09 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 07/21] fbdev/sysfs: Fix locking Daniel Vetter
2022-02-03 21:27 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 08/21] fbcon: Use delayed work for cursor Daniel Vetter
2022-01-31 21:05 ` [Intel-gfx] [PATCH 09/21] fbcon: Replace FBCON_FLAGS_INIT with a boolean Daniel Vetter
2022-02-01 10:37 ` Thomas Zimmermann
2022-02-03 13:47 ` Geert Uytterhoeven
2022-02-03 21:30 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 10/21] fb: Delete fb_info->queue Daniel Vetter
2022-02-03 21:31 ` Sam Ravnborg
2022-02-08 13:46 ` Daniel Vetter
2022-02-08 18:22 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 11/21] fbcon: Extract fbcon_open/release helpers Daniel Vetter
2022-02-03 21:15 ` Sam Ravnborg
2022-02-03 21:32 ` Sam Ravnborg
2022-02-08 13:48 ` Daniel Vetter
2022-02-08 18:24 ` Sam Ravnborg
2022-02-08 19:51 ` Daniel Vetter
2022-01-31 21:05 ` [Intel-gfx] [PATCH 12/21] fbcon: Ditch error handling for con2fb_release_oldinfo Daniel Vetter
2022-02-03 21:16 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 13/21] fbcon: move more common code into fb_open() Daniel Vetter
2022-01-31 23:31 ` kernel test robot
2022-02-04 19:35 ` Sam Ravnborg
2022-02-08 13:53 ` Daniel Vetter
2022-02-08 18:25 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 14/21] fbcon: use lock_fb_info in fbcon_open/release Daniel Vetter
2022-02-04 19:39 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 15/21] fbcon: Consistently protect deferred_takeover with console_lock() Daniel Vetter
2022-02-04 19:45 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 16/21] fbcon: Move console_lock for register/unlink/unregister Daniel Vetter
2022-02-04 19:54 ` Sam Ravnborg
2022-02-08 13:56 ` Daniel Vetter
2022-01-31 21:05 ` [Intel-gfx] [PATCH 17/21] fbcon: Move more code into fbcon_release Daniel Vetter
2022-02-04 19:55 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 18/21] fbcon: untangle fbcon_exit Daniel Vetter
2022-02-04 20:06 ` Sam Ravnborg
2022-02-08 13:58 ` Daniel Vetter
2022-02-08 18:27 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 19/21] fbcon: Maintain a private array of fb_info Daniel Vetter
2022-02-04 20:15 ` Sam Ravnborg
2022-02-08 14:03 ` Daniel Vetter
2022-02-08 18:55 ` Sam Ravnborg
2022-01-31 21:05 ` [Intel-gfx] [PATCH 20/21] Revert "fbdev: Prevent probing generic drivers if a FB is already registered" Daniel Vetter
2022-01-31 21:05 ` [Intel-gfx] [PATCH 21/21] fbdev: Make registered_fb[] private to fbmem.c Daniel Vetter
2022-02-01 8:13 ` kernel test robot
2022-02-04 8:30 ` Geert Uytterhoeven
2022-02-08 14:04 ` Daniel Vetter [this message]
2022-02-08 20:59 ` Daniel Vetter
2022-02-08 19:00 ` Sam Ravnborg
2022-02-08 20:56 ` Daniel Vetter
2022-01-31 21:16 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for some fbcon patches, mostly locking Patchwork
2022-01-31 21:19 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-01-31 21:51 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgJ4g2BEaeUELmvF@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=alexander.deucher@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jfrederich@gmail.com \
--cc=jon.nettleton@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux@roeck-us.net \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=sam@ravnborg.org \
--cc=thunder.leizhen@huawei.com \
--cc=willy@infradead.org \
--cc=xiyuyang19@fudan.edu.cn \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox