From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Move MCHBAR registers to their own header
Date: Wed, 16 Feb 2022 10:49:01 +0200 [thread overview]
Message-ID: <Ygy6fVYc5wTg+q5m@intel.com> (raw)
In-Reply-To: <20220215061342.2055952-2-matthew.d.roper@intel.com>
On Mon, Feb 14, 2022 at 10:13:42PM -0800, Matt Roper wrote:
> Registers that exist within the MCH BAR and are mirrored into the GPU's
> MMIO space are a good candidate to separate out into their own header.
>
> For reference, the mirror of the MCH BAR starts at the following
> locations in the graphics MMIO space (the end of the MCHBAR range
> differs slightly on each platform):
>
> * Pre-gen6: 0x10000
> * Gen6-Gen11 + RKL: 0x140000
>
> v2:
> - Create separate patch to swtich a few register definitions to be
> relative to the MCHBAR mirror base.
> - Drop upper bound of MCHBAR mirror from commit message; there are too
> many different combinations between various platforms to list out,
> and the documentation is spotty for the older pre-gen6 platforms
> anyway.
>
> Bspec: 134, 51771
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-02-16 8:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 6:13 [Intel-gfx] [PATCH v2 1/2] drm/i915: Define MCH registers relative to MCHBAR_MIRROR_BASE Matt Roper
2022-02-15 6:13 ` [Intel-gfx] [PATCH v2 2/2] drm/i915: Move MCHBAR registers to their own header Matt Roper
2022-02-16 8:49 ` Ville Syrjälä [this message]
2022-02-16 6:06 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915: Define MCH registers relative to MCHBAR_MIRROR_BASE Patchwork
2022-02-16 6:07 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-16 6:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-16 8:41 ` [Intel-gfx] [PATCH v2 1/2] " Ville Syrjälä
2022-02-16 11:22 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] " Patchwork
2022-02-16 20:56 ` Matt Roper
2022-02-22 17:36 ` Vudum, Lakshminarayana
2022-02-22 17:26 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygy6fVYc5wTg+q5m@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox