Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: jjherne@linux.ibm.com, akrowiak@linux.ibm.com,
	kvm@vger.kernel.org, Matthew Rosato <mjrosato@linux.ibm.com>,
	hch@infradead.org, linux-s390@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, cohuck@redhat.com,
	linux-kernel@vger.kernel.org, pasic@linux.ibm.com,
	borntraeger@linux.ibm.com, intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM
Date: Wed, 18 May 2022 00:39:41 -0700	[thread overview]
Message-ID: <YoSivTU7nivO9FMD@infradead.org> (raw)
In-Reply-To: <20220517185643.GY1343366@nvidia.com>

>  	if (device->ops->flags & VFIO_DEVICE_NEEDS_KVM)
>  	{

Nit: this is not the normal brace placement.

But what is you diff against anyway?  The one Matthew sent did away
with the VFIO_DEVICE_NEEDS_KVM flags, which does the wrong thing for
zpci, so it can't be that..

Also if we want to do major code movement, it really needs to go into
a separate patch or patches, as the combinations of all these moves
with actual code changes is almost unreadable.

  reply	other threads:[~2022-05-18  7:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220517180851.166538-1-mjrosato@linux.ibm.com>
     [not found] ` <20220517180851.166538-2-mjrosato@linux.ibm.com>
2022-05-17 18:56   ` [Intel-gfx] [PATCH 1/1] vfio: remove VFIO_GROUP_NOTIFY_SET_KVM Jason Gunthorpe
2022-05-18  7:39     ` Christoph Hellwig [this message]
2022-05-18 11:58       ` Jason Gunthorpe
2022-05-18  7:47   ` Christoph Hellwig
     [not found]   ` <2e51b388-48d0-4689-07f4-65f607dbce59@linux.ibm.com>
2022-05-18 15:12     ` Jason Gunthorpe
     [not found]       ` <34c5fd53-c75c-cb96-c627-9d30b8c45c37@linux.ibm.com>
2022-05-18 15:38         ` Jason Gunthorpe
2022-05-17 21:07 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/1] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoSivTU7nivO9FMD@infradead.org \
    --to=hch@infradead.org \
    --cc=akrowiak@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-gvt-dev@lists.freedesktop.org \
    --cc=jgg@nvidia.com \
    --cc=jjherne@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox