From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Usyskin <alexander.usyskin@intel.com>
Cc: David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Vitaly Lubart <vitaly.lubart@intel.com>
Subject: Re: [Intel-gfx] [PATCH v4 13/14] mei: debugfs: add pxp mode to devstate in debugfs
Date: Wed, 29 Jun 2022 17:39:17 +0200 [thread overview]
Message-ID: <YrxyJROfuLpVYDjF@kroah.com> (raw)
In-Reply-To: <20220629112913.1210933-14-alexander.usyskin@intel.com>
On Wed, Jun 29, 2022 at 02:29:12PM +0300, Alexander Usyskin wrote:
> From: Tomas Winkler <tomas.winkler@intel.com>
>
> Add pxp mode devstate to debugfs to monitor
> pxp state machine progress. During debug
> it is important to understand in what state
> the pxp handshake is.
You have 72 columns for changelog text, as your editor will tell you
when you run git commit...
Anyway, it's better than nothing, but really, do you think this is a
good changelog description? That last sentence means nothing. I too
think it is important to understand things...
{sigh}
Anyway, you all are pushing this hard for some crazy reason, and it's
only a debugfs file, so it doesn't matter much, but it feels indicative
of other patches from your employer for the past few years so I'll be a
pain and ask for you to fix it up again.
thanks,
greg k-h
next prev parent reply other threads:[~2022-06-29 15:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 11:28 [Intel-gfx] [PATCH v4 00/14] GSC support for XeHP SDV and DG2 platforms Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 01/14] HAX: drm/i915: force INTEL_MEI_GSC on for CI Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 02/14] drm/i915/gsc: skip irq initialization if using polling Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 03/14] drm/i915/gsc: add slow_fw flag to the mei auxiliary device Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 04/14] drm/i915/gsc: add slow_fw flag to the gsc device definition Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 05/14] drm/i915/gsc: add GSC XeHP SDV platform definition Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 06/14] mei: gsc: use polling instead of interrupts Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 07/14] mei: gsc: wait for reset thread on stop Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 08/14] mei: extend timeouts on slow devices Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 09/14] mei: bus: export common mkhi definitions into a separate header Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 10/14] mei: mkhi: add memory ready command Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 11/14] mei: gsc: setup gsc extended operational memory Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 12/14] mei: gsc: add transition to PXP mode in resume flow Alexander Usyskin
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 13/14] mei: debugfs: add pxp mode to devstate in debugfs Alexander Usyskin
2022-06-29 15:39 ` Greg Kroah-Hartman [this message]
2022-06-29 15:39 ` Greg Kroah-Hartman
2022-06-29 11:29 ` [Intel-gfx] [PATCH v4 14/14] drm/i915/gsc: allocate extended operational memory in LMEM Alexander Usyskin
2022-06-29 12:52 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for GSC support for XeHP SDV and DG2 platforms (rev4) Patchwork
2022-06-29 15:40 ` [Intel-gfx] [PATCH v4 00/14] GSC support for XeHP SDV and DG2 platforms Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrxyJROfuLpVYDjF@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@linux.ie \
--cc=alexander.usyskin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tomas.winkler@intel.com \
--cc=vitaly.lubart@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox