Re: [Intel-gfx] [PATCH v2 1/5] drm/i915/crt: remove BUG_ON()

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Aug 30, 2022 at 12:34:07PM +0300, Jani Nikula wrote:
> Avoid BUG_ON(). We don't have such checks on output type anywhere else
> either, so just remove.
> 
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_crt.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_crt.c b/drivers/gpu/drm/i915/display/intel_crt.c
> index 6a3893c8ff22..d766c506b235 100644
> --- a/drivers/gpu/drm/i915/display/intel_crt.c
> +++ b/drivers/gpu/drm/i915/display/intel_crt.c
> @@ -643,8 +643,6 @@ static bool intel_crt_detect_ddc(struct drm_connector *connector)
>  	struct i2c_adapter *i2c;
>  	bool ret = false;
>  
> -	BUG_ON(crt->base.type != INTEL_OUTPUT_ANALOG);
> -
>  	i2c = intel_gmbus_get_adapter(dev_priv, dev_priv->vbt.crt_ddc_pin);
>  	edid = intel_crt_get_edid(connector, i2c);
>  
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel