From: Andi Shyti <andi.shyti@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, drm-devel@lists.freedesktop.org,
Daniel Vetter <daniel@ffwll.ch>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection
Date: Wed, 14 Sep 2022 19:50:49 +0200 [thread overview]
Message-ID: <YyIUeb35VM8nwE5i@alfio.lan> (raw)
In-Reply-To: <d338517e-853e-98a5-1e24-59f43f2ac212@linux.intel.com>
Hi,
[...]
> > struct i915_address_space *vm;
> > + unsigned long flags;
> > trace_i915_context_free(ctx);
> > GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
> > + spin_lock_irqsave(&ctx->i915->gem.contexts.lock, flags);
>
> Why irqsave and the conversion to irq safe elsewhere? Worker context does
> not require it and I don't see the connection to the change of list_del
> location.
yah! I think there is no reason, this is just inherited from
other code.
Andi
> Regards,
>
> Tvrtko
>
> > + list_del(&ctx->link);
> > + spin_unlock_irqrestore(&ctx->i915->gem.contexts.lock, flags);
> > +
> > if (ctx->syncobj)
> > drm_syncobj_put(ctx->syncobj);
...
next prev parent reply other threads:[~2022-09-14 17:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 16:10 [Intel-gfx] [PATCH 0/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
2022-09-13 16:10 ` [Intel-gfx] [PATCH 1/2] drm/i915/gem: Flush contexts on driver release Janusz Krzysztofik
2022-09-14 13:56 ` Andi Shyti
2022-09-13 16:10 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Really move i915_gem_context.link under ref protection Janusz Krzysztofik
2022-09-14 15:15 ` Andi Shyti
2022-09-14 16:09 ` Janusz Krzysztofik
2022-09-14 15:37 ` Tvrtko Ursulin
2022-09-14 16:24 ` Janusz Krzysztofik
2022-09-14 17:50 ` Andi Shyti [this message]
2022-09-13 21:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: Really move i915_gem_context.link under ref protection (rev2) Patchwork
2022-09-13 21:39 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-13 22:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-14 12:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-09-14 13:59 ` Andi Shyti
2022-09-14 15:45 ` Patchwork
2022-09-14 16:35 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyIUeb35VM8nwE5i@alfio.lan \
--to=andi.shyti@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=drm-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox