From: Andi Shyti <andi.shyti@linux.intel.com>
To: Sk Anirban <sk.anirban@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Badal Nilawar <badal.nilawar@intel.com>
Subject: Re: [PATCH v5] drm/i915/selftests: Refactor RC6 power measurement and error handling
Date: Tue, 1 Apr 2025 09:24:17 +0200 [thread overview]
Message-ID: <Z-uUoQateb-QHxSS@ashyti-mobl2.lan> (raw)
In-Reply-To: <20250327191924.4131598-1-sk.anirban@intel.com>
Hi Anirban,
On Fri, Mar 28, 2025 at 12:49:24AM +0530, Sk Anirban wrote:
> Revise the power measurement logic to save and evaluate energy values.
How is the logic been revised? Can you be more specific please?
> Previously, the test only checked whether the system had entered the RC6
> state, without considering any potential interruptions in that state.
> This update introduces a threshold check to ensure that the GPU remains
> in the RC6 state properly during the specified sleep duration.
How is the threshold been evaluated? As far as I can see, there
is only one pr_err() added in a path that fails anyway (it's
almost more a debug). Should we evaluate the threshold outside
from the failing path?
Andi
next prev parent reply other threads:[~2025-04-01 7:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 19:19 [PATCH v5] drm/i915/selftests: Refactor RC6 power measurement and error handling Sk Anirban
2025-03-27 20:42 ` ✓ i915.CI.BAT: success for drm/i915/selftests: Refactor RC6 power measurement and error handling (rev6) Patchwork
2025-03-28 0:21 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-28 6:08 ` ✓ i915.CI.Full: success " Patchwork
2025-04-01 7:24 ` Andi Shyti [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-19 17:08 [PATCH v5] drm/i915/selftests: Refactor RC6 power measurement and error handling Sk Anirban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-uUoQateb-QHxSS@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sk.anirban@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox