From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Zhang He <zhanghe9702@163.com>
Cc: <intel-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Fixed an typo in i915_gem_gtt.c
Date: Mon, 25 Nov 2024 11:00:13 -0500 [thread overview]
Message-ID: <Z0SfDbx5C4sMvIQg@intel.com> (raw)
In-Reply-To: <20241120123245.71101-1-zhanghe9702@163.com>
On Wed, Nov 20, 2024 at 08:32:45PM +0800, Zhang He wrote:
> in function `i915_gem_gtt_reserve` @node comment,
> i915_vma has no `mode` member, `i915_vma.node` is the correct name
>
> Signed-off-by: Zhang He <zhanghe9702@163.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushed to drm-intel-next. Thanks for the patch
> ---
> drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index a9662cc6ed1e..25295eb626dc 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -71,7 +71,7 @@ void i915_gem_gtt_finish_pages(struct drm_i915_gem_object *obj,
> * i915_gem_gtt_reserve - reserve a node in an address_space (GTT)
> * @vm: the &struct i915_address_space
> * @ww: An optional struct i915_gem_ww_ctx.
> - * @node: the &struct drm_mm_node (typically i915_vma.mode)
> + * @node: the &struct drm_mm_node (typically i915_vma.node)
> * @size: how much space to allocate inside the GTT,
> * must be #I915_GTT_PAGE_SIZE aligned
> * @offset: where to insert inside the GTT,
> --
> 2.43.0
>
prev parent reply other threads:[~2024-11-25 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 12:32 [PATCH] drm/i915: Fixed an typo in i915_gem_gtt.c Zhang He
2024-11-25 13:02 ` ✓ i915.CI.BAT: success for " Patchwork
2024-11-25 14:51 ` ✗ i915.CI.Full: failure " Patchwork
2024-11-25 16:00 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0SfDbx5C4sMvIQg@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhanghe9702@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox