Re: [PATCH v3] drm/i915/gt: Use spin_lock_irqsave() in interruptible context

[Andi Shyti <andi.shyti@linux.intel.com>]

Hi Krzysztof,

On Thu, Jan 16, 2025 at 10:40:46AM +0000, Krzysztof Karas wrote:
> spin_lock/unlock() functions used in interrupt contexts could
> result in a deadlock, as seen in GitLab issue #13399:
> https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13399,

I moved this link in the tag sectoin as Closes:

> which occurs when interrupt comes in while holding a lock.
> 
> Try to remedy the problem by saving irq state before spin lock
> acquisition.
> 
> v2: add irqs' state save/restore calls to all locks/unlocks in
>  signal_irq_work() execution (Maciej)
> 
> v3: use with spin_lock_irqsave() in guc_lrc_desc_unpin() instead
>  of other lock/unlock calls and add Fixes and Cc tags (Tvrtko);
>  change title and commit message
> 
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
> Fixes: 2f2cc53b5fe7 ("drm/i915/guc: Close deregister-context race against CT-loss")

I moved Fixes: above your SoB.

> Cc: <stable@vger.kernel.org> # v6.9+

Anyway, good catch, but please, remember next time to relly add
in Cc the stable kernel mailing list, the guc guys in Cc for GuC
related patches and the author of the patch you are fixing.

Reviewed and merged in drm-intel-gt-next.

Thanks,
Andi